diff options
| author | Weihang Lo <me@weihanglo.tw> | 2024-05-23 20:36:39 +0000 |
|---|---|---|
| committer | Weihang Lo <me@weihanglo.tw> | 2024-06-09 12:33:11 -0400 |
| commit | e24be071e3bef8dfb84b082f1478e9d33a108901 (patch) | |
| tree | 01ab0f4f5b892a2603f8d61dcc2e4dc023dad3ca /compiler/rustc_pattern_analysis/src/errors.rs | |
| parent | 8a0f1957982a6042ec550147243f811f25889d9c (diff) | |
| download | rust-e24be071e3bef8dfb84b082f1478e9d33a108901.tar.gz rust-e24be071e3bef8dfb84b082f1478e9d33a108901.zip | |
feat: vendor crates required by opt-dist to collect profiles
These are the default package set required by opt-dist to correctly work, hence for people wanting to build a production grade of rustc in a sandboxed / air-gapped environment, these need to be vendored. The size of `rustc-src-nightly.tar.xz` before and after this change: * Before: 298M * After: 323M (+8%) These crates are the default set of packages required by opt-dist to correctly work, hence for people wanting to build a production grade of rustc in an sandboxed / air-gapped environment, these need to be vendored. The size of `rustc-src-nightly.tar.xz` before and after this change: * Before: 298M * After: 323M (+8%) Size change might or might not be a concern. See the previous discussion: https://github.com/rust-lang/rust/pull/125166#issuecomment-2113626468 Previous efforts on making: * https://github.com/rust-lang/rust/pull/125125 * https://github.com/rust-lang/rust/pull/125166 --- Note that extra works still need to be done to make it fully vendored. * The current pinned rustc-perf uses `tempfile::Tempdir` as the working directory when collecting profiles from some of these packages. This "tmp" working directory usage make it impossible for Cargo to pick up the correct vendor sources setting in `.cargo/config.toml` bundled in the rustc-src tarball. [^1] * opt-dist verifies the final built rustc against a subset of rustc test suite. However it rolls out its own `config.toml` without setting `vendor = true`, and that results in `./vendor/` directory removed. [^2] [^1]: https://github.com/rust-lang/rustc-perf/blob/4f313add609f43e928e98132358e8426ed3969ae/collector/src/compile/benchmark/mod.rs#L164-L173 [^2]: https://github.com/rust-lang/rust/blob/606afbb617a2949a4e35c4b0258ff94c980b9451/src/tools/opt-dist/src/tests.rs#L62-L77
Diffstat (limited to 'compiler/rustc_pattern_analysis/src/errors.rs')
0 files changed, 0 insertions, 0 deletions