diff options
| author | Guillaume Gomez <guillaume1.gomez@gmail.com> | 2024-01-20 20:06:33 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-20 20:06:33 +0100 |
| commit | 1236fa2102a5105059d32a00f8f4104d6677bdb4 (patch) | |
| tree | 170d9c14135f7d5428710608877f7f7997a04837 /compiler/rustc_pattern_analysis/src | |
| parent | 159bdc1e9313d63ed97ae79fd7c6037393f3ab88 (diff) | |
| parent | 0933f48ac0a8631b3f7c9c508f38843ef10e839d (diff) | |
| download | rust-1236fa2102a5105059d32a00f8f4104d6677bdb4.tar.gz rust-1236fa2102a5105059d32a00f8f4104d6677bdb4.zip | |
Rollup merge of #119997 - GuillaumeGomez:fix-stripped-impl-on-ty-alias, r=notriddle
Fix impl stripped in rustdoc HTML whereas it should not be in case the impl is implemented on a type alias Fixes #119015. I talked about it a bit with ```@petrochenkov.``` They might change what `EffectiveVisibilities` return for impl items like this one and make them not only reachable but also re-exported, which would fix this case. It could also potentially break other things, so it'll be done whenever they can and then we can check together. Surprisingly, this fix is making rustdoc even closer to rustc in term of errors (the CI currently fails because currently accepted broken codes aren't working anymore with this change). Not sure exactly why though. This is linked to https://github.com/rust-lang/rust/pull/110631 from what I could find. So either I'm missing something here, or we consider it's ok and we consider the failing tests as "should fail" and I'll update `rustdoc-ui` ones. r? ```@notriddle```
Diffstat (limited to 'compiler/rustc_pattern_analysis/src')
0 files changed, 0 insertions, 0 deletions
