diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2024-07-14 10:05:20 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-14 10:05:20 +0200 |
| commit | 60e10e65ba428212833a1a8bc54a5f28cba36013 (patch) | |
| tree | 639fbafa2d522d9a03983dcf77749597f3c26238 /compiler/rustc_pattern_analysis/src | |
| parent | 459120d98364cfacae9812be38f2d6557ec70120 (diff) | |
| parent | 335bdd4eec418f3572ef532e111979681e14602c (diff) | |
| download | rust-60e10e65ba428212833a1a8bc54a5f28cba36013.tar.gz rust-60e10e65ba428212833a1a8bc54a5f28cba36013.zip | |
Rollup merge of #127322 - onur-ozkan:ci-rustc-incompatible-options, r=Mark-Simulacrum
handle ci-rustc incompatible options during config parse This PR ensures that `config.toml` does not use CI rustc incompatible options when CI rustc is enabled (just like [ci-llvm checks](https://github.com/rust-lang/rust/blob/e2cf31a6148725bde4ea48acf1e4fe72675257a2/src/bootstrap/src/core/config/config.rs#L1809-L1836)). Some options can change compiler's behavior in certain scenarios. If we don't check these incompatible options, CI runners using CI rustc might ignore options we have explicitly set. This could be dangerous as we might think a rustc test passed with option T but in fact it wasn't tested with option T. Later in https://github.com/rust-lang/rust/pull/122709, I will disable CI rustc if any of those options were used (similar to [this approach](https://github.com/rust-lang/rust/blob/dd2c24aafddbd9cc170f32f5b447c7d3005c7412/src/ci/run.sh#L165-L169)). If CI runners fail because of these checks, it means the logic in run.sh isn't covering the incompatible options correctly (since any incompatible option should turn off CI rustc). The list may not be complete, but should be a good first step as it's better than nothing! Blocker for https://github.com/rust-lang/rust/pull/122709
Diffstat (limited to 'compiler/rustc_pattern_analysis/src')
0 files changed, 0 insertions, 0 deletions