about summary refs log tree commit diff
path: root/compiler/rustc_query_impl/src
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2021-07-17 07:54:03 +0000
committerbors <bors@rust-lang.org>2021-07-17 07:54:03 +0000
commit153df0f6ef0f3ff00b12122774825507fd88169f (patch)
tree1bbda7e1097247acf8af15c872f25458c6a15417 /compiler/rustc_query_impl/src
parent0cd12d649ea966648cc2c7c5dec8f4933d6fa355 (diff)
parentf4701cd65cf6b3f9707b2bd20865d462f758a7f5 (diff)
downloadrust-153df0f6ef0f3ff00b12122774825507fd88169f.tar.gz
rust-153df0f6ef0f3ff00b12122774825507fd88169f.zip
Auto merge of #86062 - nagisa:nagisa/what-a-lie, r=estebank
Do not allow JSON targets to set is-builtin: true

Note that this will affect (and make builds fail for) all of the projects out there that have target files invalid in this way. Crater, however, does not really cover these kinds of the codebases, so it is quite difficult to measure the impact. That said, the target files invalid in this way can start causing build failures each time LLVM is upgraded, anyway, so it is probably a good opportunity to disallow this property, entirely.

Another approach considered was to simply not parse this field anymore, which would avoid making the builds explicitly fail, but it wasn't clear to me if `is-builtin` was always set unintentionally… In case this was the case, I'd expect people to file a feature request stating specifically for what purpose they were using `is-builtin`.

Fixes #86017
Diffstat (limited to 'compiler/rustc_query_impl/src')
0 files changed, 0 insertions, 0 deletions