diff options
| author | bors <bors@rust-lang.org> | 2024-04-19 12:11:09 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2024-04-19 12:11:09 +0000 |
| commit | 07d0d7ce3fd22e4fadd61206034af6fadcdb3e4f (patch) | |
| tree | 667f9914d726141ba51a5b3021f9fb49f7a262f1 /compiler/rustc_trait_selection/src/traits/auto_trait.rs | |
| parent | 43a0686f8d18fa068e2689d5bd889bd2670dbf50 (diff) | |
| parent | 1d929cf8b719dd454b7966449ed8666bfa485de3 (diff) | |
| download | rust-07d0d7ce3fd22e4fadd61206034af6fadcdb3e4f.tar.gz rust-07d0d7ce3fd22e4fadd61206034af6fadcdb3e4f.zip | |
Auto merge of #123364 - klensy:bs-mixed-types, r=albertlarsan68
bootstrap: actually allow set debuginfo-level to "line-tables-only"
I've tried to set in config.toml `rust.debuginfo-level = "line-tables-only"`, but ended with:
``` failed to parse TOML configuration 'config.toml':
data did not match any variant of untagged enum StringOrInt for key `rust.debuginfo-level`
```
Also this PR allows to set `line-directives-only` for debuginfo in config.toml too.
1. Fixes this. Alternative is remove that Deserialize and use default one:
https://github.com/rust-lang/rust/blob/0e682e9875458ebf811206a48b688e07d762d9bb/src/bootstrap/src/core/config/config.rs#L725-L728
2. Should `line-directives-only` be added too?
3. I've tried to add test to rust/src/bootstrap/src/core/config/tests.rs:
```rust
#[test]
fn rust_debuginfo() {
assert!(matches!(
parse("rust.debuginfo-level-rustc = 1").rust_debuginfo_level_rustc,
DebuginfoLevel::Limited
));
assert!(matches!(
parse("rust.debuginfo-level-rustc = \"line-tables-only\"").rust_debuginfo_level_rustc,
DebuginfoLevel::LineTablesOnly
));
}
```
But test passes before that PR too; looks like config parse tests checks something wrong? I mean, that tests check something which isn't actual bootstrap behavior.
Diffstat (limited to 'compiler/rustc_trait_selection/src/traits/auto_trait.rs')
0 files changed, 0 insertions, 0 deletions
