about summary refs log tree commit diff
path: root/compiler/rustc_trait_selection/src
diff options
context:
space:
mode:
authorWill Crichton <wcrichto@cs.stanford.edu>2022-07-15 18:02:26 -0700
committerWill Crichton <wcrichto@cs.stanford.edu>2022-07-15 18:06:20 -0700
commit2f15dfab0b444e757dcb32d935a716a5785b2155 (patch)
tree5ef48e1a716180e6e3230b1ac1b8c6ed9f6de657 /compiler/rustc_trait_selection/src
parente5bb7d80d698102175dbbb4094bec03b682e8399 (diff)
downloadrust-2f15dfab0b444e757dcb32d935a716a5785b2155.tar.gz
rust-2f15dfab0b444e757dcb32d935a716a5785b2155.zip
Fix suggestion regression with incorrect syntactic combination of trait bounds
Diffstat (limited to 'compiler/rustc_trait_selection/src')
-rw-r--r--compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs14
1 files changed, 13 insertions, 1 deletions
diff --git a/compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs b/compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
index 469436ff0db..bca80e7ab8a 100644
--- a/compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
+++ b/compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
@@ -599,7 +599,19 @@ impl<'a, 'tcx> InferCtxtExt<'tcx> for InferCtxt<'a, 'tcx> {
                     if let Some(proj_pred) = proj_pred {
                         let ProjectionPredicate { projection_ty, term } = proj_pred.skip_binder();
                         let item = self.tcx.associated_item(projection_ty.item_def_id);
-                        constraint.push_str(&format!("<{}={}>", item.name, term.to_string()));
+
+                        // FIXME: this case overlaps with code in TyCtxt::note_and_explain_type_err.
+                        // That should be extracted into a helper function.
+                        if constraint.ends_with('>') {
+                            constraint = format!(
+                                "{}, {}={}>",
+                                &constraint[..constraint.len() - 1],
+                                item.name,
+                                term.to_string()
+                            );
+                        } else {
+                            constraint.push_str(&format!("<{}={}>", item.name, term.to_string()));
+                        }
                     }
 
                     if suggest_constraining_type_param(