about summary refs log tree commit diff
path: root/compiler
diff options
context:
space:
mode:
authorBen Kimock <kimockb@gmail.com>2023-12-10 23:04:50 -0500
committerBen Kimock <kimockb@gmail.com>2023-12-10 23:26:40 -0500
commit79bdd24d6ee1022e4a02fd00a490279c7f0a4f98 (patch)
treeeabe309c15fad8e64b7ef99009dbcdf20ae9c406 /compiler
parentb94cfefc860715fb2adf72a6955423d384c69318 (diff)
Apply suggestions from code review
Co-authored-by: Waffle Maybe <waffle.lapkin@gmail.com>
Diffstat (limited to 'compiler')
-rw-r--r--compiler/rustc_codegen_ssa/src/back/metadata.rs2
-rw-r--r--compiler/rustc_metadata/src/rmeta/decoder.rs3
2 files changed, 2 insertions, 3 deletions
diff --git a/compiler/rustc_codegen_ssa/src/back/metadata.rs b/compiler/rustc_codegen_ssa/src/back/metadata.rs
index aaf75819e97..d5a223c1a7b 100644
--- a/compiler/rustc_codegen_ssa/src/back/metadata.rs
+++ b/compiler/rustc_codegen_ssa/src/back/metadata.rs
@@ -162,7 +162,7 @@ pub(super) fn get_metadata_xcoff<'a>(path: &Path, data: &'a [u8]) -> Result<&'a
             return Err(format!("Invalid metadata symbol offset: {offset}"));
         }
         // The offset specifies the location of rustc metadata in the comment section.
-        // The metadata is preceded by a 4-byte length field.
+        // The metadata is preceded by a 8-byte length field.
         let len = u64::from_le_bytes(info_data[(offset - 8)..offset].try_into().unwrap()) as usize;
         if offset + len > (info_data.len() as usize) {
             return Err(format!(
diff --git a/compiler/rustc_metadata/src/rmeta/decoder.rs b/compiler/rustc_metadata/src/rmeta/decoder.rs
index 9aaa72cfc80..ff0b8cad333 100644
--- a/compiler/rustc_metadata/src/rmeta/decoder.rs
+++ b/compiler/rustc_metadata/src/rmeta/decoder.rs
@@ -705,9 +705,8 @@ impl MetadataBlob {
     }
 
     fn root_pos(&self) -> NonZeroUsize {
-        let slice = &self.blob()[..];
         let offset = METADATA_HEADER.len();
-        let pos_bytes = slice[offset..][..8].try_into().unwrap();
+        let pos_bytes = self.blob()[offset..][..8].try_into().unwrap();
         let pos = u64::from_le_bytes(pos_bytes);
         NonZeroUsize::new(pos as usize).unwrap()
     }