about summary refs log tree commit diff
path: root/compiler
diff options
context:
space:
mode:
authorCamille GILLOT <gillot.camille@gmail.com>2021-06-30 20:52:00 +0200
committerCamille GILLOT <gillot.camille@gmail.com>2021-06-30 20:56:49 +0200
commitf69877426a6a65fceccaedf9a1e82fa5f05de9d2 (patch)
tree6d189d535b7b79226cb465669d49846f14e6933f /compiler
parentaa1bc5874eb43868151b1c2f667086547af65726 (diff)
downloadrust-f69877426a6a65fceccaedf9a1e82fa5f05de9d2.tar.gz
rust-f69877426a6a65fceccaedf9a1e82fa5f05de9d2.zip
Update comments.
Diffstat (limited to 'compiler')
-rw-r--r--compiler/rustc_interface/src/passes.rs17
1 files changed, 5 insertions, 12 deletions
diff --git a/compiler/rustc_interface/src/passes.rs b/compiler/rustc_interface/src/passes.rs
index 63aa3db63ff..9ea1f88b43f 100644
--- a/compiler/rustc_interface/src/passes.rs
+++ b/compiler/rustc_interface/src/passes.rs
@@ -100,7 +100,7 @@ mod boxed_resolver {
     }
 
     // Note: Drop order is important to prevent dangling references. Resolver must be dropped first,
-    // then resolver_arenas and finally session.
+    // then resolver_arenas and session.
     impl Drop for BoxedResolverInner {
         fn drop(&mut self) {
             self.resolver.take();
@@ -109,10 +109,10 @@ mod boxed_resolver {
     }
 
     impl BoxedResolver {
-        pub(super) fn new<F>(session: Lrc<Session>, make_resolver: F) -> Self
-        where
-            F: for<'a> FnOnce(&'a Session, &'a ResolverArenas<'a>) -> Resolver<'a>,
-        {
+        pub(super) fn new(
+            session: Lrc<Session>,
+            make_resolver: impl for<'a> FnOnce(&'a Session, &'a ResolverArenas<'a>) -> Resolver<'a>,
+        ) -> BoxedResolver {
             let mut boxed_resolver = Box::new(BoxedResolverInner {
                 session,
                 resolver_arenas: Some(Resolver::arenas()),
@@ -168,11 +168,6 @@ pub fn create_resolver(
     crate_name: &str,
 ) -> BoxedResolver {
     tracing::trace!("create_resolver");
-    // Currently, we ignore the name resolution data structures for the purposes of dependency
-    // tracking. Instead we will run name resolution and include its output in the hash of each
-    // item, much like we do for macro expansion. In other words, the hash reflects not just
-    // its contents but the results of name resolution on those contents. Hopefully we'll push
-    // this back at some point.
     BoxedResolver::new(sess, move |sess, resolver_arenas| {
         Resolver::new(sess, &krate, &crate_name, metadata_loader, &resolver_arenas)
     })
@@ -263,8 +258,6 @@ fn pre_expansion_lint(
 /// syntax expansion, secondary `cfg` expansion, synthesis of a test
 /// harness if one is to be provided, injection of a dependency on the
 /// standard library and prelude, and name resolution.
-///
-/// Returns [`None`] if we're aborting after handling -W help.
 pub fn configure_and_expand(
     sess: &Session,
     lint_store: &LintStore,