about summary refs log tree commit diff
path: root/docs/dev/debugging.md
diff options
context:
space:
mode:
authorbors[bot] <26634292+bors[bot]@users.noreply.github.com>2020-05-27 12:41:38 +0000
committerGitHub <noreply@github.com>2020-05-27 12:41:38 +0000
commit59adc7bfb6084e946afbea40351c3f6653c37174 (patch)
treedad3828436c3f8ee65bd2a2e18d04aa3a094d786 /docs/dev/debugging.md
parent3c5112b079211640ed865ed1d26d8cd2f041c8c4 (diff)
parentfd83f469e9643c7a9da2d9e4c796bd89c441458d (diff)
downloadrust-59adc7bfb6084e946afbea40351c3f6653c37174.tar.gz
rust-59adc7bfb6084e946afbea40351c3f6653c37174.zip
Merge #4596
4596: Strip leading underscores of argument names in function/method r=matklad a=kuy

Closes #4510 

### Goal

When I select a function/method from completions, I get a snippet that doesn't contain leading underscores of argument names.

### Solution

- Option 1: All signatures don't contain underscores
- Option 2: Keep same signature, but inserted snippet doesn't contain underscores

I choose Option 2 because I think that leading underscores is a part of "signature". Users should get correct signatures. On the other hand, trimming underscores is an assist by IDE.

### Other impls.

rls: Complete argument names with underscores (same as actual ra)
IntelliJ Rust: Doesn't complete argument names
VSCode (TypeScript): Doesn't complete argument names

### Working example

![Screen Shot 2020-05-25 at 0 03 21](https://user-images.githubusercontent.com/151614/82757771-a05e5b80-9e1d-11ea-9dbc-1263c960e2ae.png)


Co-authored-by: Yuki Kodama <endflow.net@gmail.com>
Diffstat (limited to 'docs/dev/debugging.md')
0 files changed, 0 insertions, 0 deletions