diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-04-19 07:57:40 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-04-19 07:57:40 +0000 |
| commit | 75bf8328994e0966d381061647ac7dbbce374b39 (patch) | |
| tree | 1fadb1bc57f4d666a427137dee8da7922b46f304 /docs/dev | |
| parent | 0308fd6dabfce2d13e7e9c5b2a779be73579fa31 (diff) | |
| parent | 493aaa140325f3b8fa40de3de58b34e4b96c5d13 (diff) | |
| download | rust-75bf8328994e0966d381061647ac7dbbce374b39.tar.gz rust-75bf8328994e0966d381061647ac7dbbce374b39.zip | |
Merge #8540
8540: Prevent being able to rename items that are not part of the workspace r=Veykril a=Veykril This change causes renames that happen on items coming from crates outside the workspace to fail. I believe this should be the right approach, but usage of cargo's workspace might not be entirely correct for preventing these kinds of refactoring from touching things they shouldn't. I'm not entirely sure? cc #6623, this is one of the bigger footguns when it comes to refactoring, especially in combination with import aliases people tend to rename items coming from a crates dependency which this prevents. Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Diffstat (limited to 'docs/dev')
| -rw-r--r-- | docs/dev/lsp-extensions.md | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/docs/dev/lsp-extensions.md b/docs/dev/lsp-extensions.md index a4d92242b77..a112477de87 100644 --- a/docs/dev/lsp-extensions.md +++ b/docs/dev/lsp-extensions.md @@ -1,5 +1,5 @@ <!--- -lsp_ext.rs hash: b19ddc3ab8767af9 +lsp_ext.rs hash: 28a9d5a24b7ca396 If you need to change the above hash to make the test pass, please check if you need to adjust this doc as well and ping this issue: @@ -46,6 +46,7 @@ If this capability is set, `WorkspaceEdit`s returned from `codeAction` requests ```typescript interface SnippetTextEdit extends TextEdit { insertTextFormat?: InsertTextFormat; + annotationId?: ChangeAnnotationIdentifier; } ``` |