about summary refs log tree commit diff
path: root/editors/code/src/run.ts
diff options
context:
space:
mode:
authorAleksey Kladov <aleksey.kladov@gmail.com>2022-10-08 23:18:11 +0100
committerAleksey Kladov <aleksey.kladov@gmail.com>2022-10-08 23:25:13 +0100
commit5bbfea03ccada14bbaca6df6c0ef3760ac44a9a5 (patch)
tree63f1d3a2957edc137970f90ceadb5ee675816d53 /editors/code/src/run.ts
parent61504c8d951c566eb03037dcb300c96f4bd9a8b6 (diff)
downloadrust-5bbfea03ccada14bbaca6df6c0ef3760ac44a9a5.tar.gz
rust-5bbfea03ccada14bbaca6df6c0ef3760ac44a9a5.zip
fix: in VSCode, correctly resolve relative paths to errors
VS Code problem matcher are restricted to be static "regexes". You can't
create a problem matcher dynamically, and you can't use custom code in
lieu of problem matcher.

This creates a problem for rust/cargo compiler errors. They use paths
relative to the root of the Cargo workspace, but VS Code doesn't
necessary know where that root is.

Luckily, there's a way out: our current problem matcher is defined like
this:

    "fileLocation": [ "autoDetect", "${workspaceRoot}" ],

That means that relative pahts would be resoleved relative to workspace
root. VS Code allows to specify a command inside `${}`. So we can plug
custom logic there to fetch Cargo's workspace root!

And that's exactly what this PR is doing!
Diffstat (limited to 'editors/code/src/run.ts')
-rw-r--r--editors/code/src/run.ts2
1 files changed, 2 insertions, 0 deletions
diff --git a/editors/code/src/run.ts b/editors/code/src/run.ts
index 22e5eda6827..100c0fe2d8c 100644
--- a/editors/code/src/run.ts
+++ b/editors/code/src/run.ts
@@ -89,12 +89,14 @@ export async function selectRunnable(
 
 export class RunnableQuickPick implements vscode.QuickPickItem {
     public label: string;
+    public cargoWorkspaceRoot?: string;
     public description?: string | undefined;
     public detail?: string | undefined;
     public picked?: boolean | undefined;
 
     constructor(public runnable: ra.Runnable) {
         this.label = runnable.label;
+        this.cargoWorkspaceRoot = runnable.args.workspaceRoot;
     }
 }