diff options
| author | Edwin Cheng <edwin@m-inverse.com> | 2019-04-02 17:13:14 +0800 |
|---|---|---|
| committer | Edwin Cheng <edwin@m-inverse.com> | 2019-04-02 17:13:14 +0800 |
| commit | 9d269849987fbe374b0f76a4893fdf9d867b8b84 (patch) | |
| tree | 5d5685228eab14976d9bd0e2205b466f9e70ed9a /editors/code/src/utils | |
| parent | 06053a0a7636b620d36d49678a5d73424e0010e9 (diff) | |
| download | rust-9d269849987fbe374b0f76a4893fdf9d867b8b84.tar.gz rust-9d269849987fbe374b0f76a4893fdf9d867b8b84.zip | |
Add terminate process implemntation note
Diffstat (limited to 'editors/code/src/utils')
| -rw-r--r-- | editors/code/src/utils/processes.ts | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/editors/code/src/utils/processes.ts b/editors/code/src/utils/processes.ts index d4c2c87782a..f62e2a346d7 100644 --- a/editors/code/src/utils/processes.ts +++ b/editors/code/src/utils/processes.ts @@ -8,6 +8,13 @@ import { join } from 'path'; const isWindows = process.platform === 'win32'; const isMacintosh = process.platform === 'darwin'; const isLinux = process.platform === 'linux'; + +// this is very complex, but is basically copy-pased from VSCode implementation here: +// https://github.com/Microsoft/vscode-languageserver-node/blob/dbfd37e35953ad0ee14c4eeced8cfbc41697b47e/client/src/utils/processes.ts#L15 + +// And see discussion at +// https://github.com/rust-analyzer/rust-analyzer/pull/1079#issuecomment-478908109 + export function terminate(process: ChildProcess, cwd?: string): boolean { if (isWindows) { try { |
