diff options
| author | Veetaha <veetaha2@gmail.com> | 2020-08-21 22:12:22 +0300 |
|---|---|---|
| committer | Veetaha <veetaha2@gmail.com> | 2020-08-21 22:15:04 +0300 |
| commit | 74ed42c8e9057bdd8910d0eba03ea0b30b87e660 (patch) | |
| tree | fada52f7e8b78cd2ca69e63404bc7ac294d4fabf /editors/code/src | |
| parent | aab5aaccf2b1af8f1820a244a2c293c7460f9eb6 (diff) | |
| download | rust-74ed42c8e9057bdd8910d0eba03ea0b30b87e660.tar.gz rust-74ed42c8e9057bdd8910d0eba03ea0b30b87e660.zip | |
Gate stream.pipeline workaround on fixed versions of node
Diffstat (limited to 'editors/code/src')
| -rw-r--r-- | editors/code/src/net.ts | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/editors/code/src/net.ts b/editors/code/src/net.ts index 681eaa9c946..5eba2728d28 100644 --- a/editors/code/src/net.ts +++ b/editors/code/src/net.ts @@ -134,6 +134,14 @@ async function downloadFile( await pipeline(srcStream, destFileStream); + // Don't apply the workaround in fixed versions of nodejs, since the process + // freezes on them, the process waits for no-longer emitted `close` event. + // The fix was applied in commit 7eed9d6bcc in v13.11.0 + // See the nodejs changelog: + // https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V13.md + const [, major, minor] = /v(\d+)\.(\d+)\.(\d+)/.exec(process.version)!; + if (+major > 13 || (+major === 13 && +minor >= 11)) return; + await new Promise<void>(resolve => { destFileStream.on("close", resolve); destFileStream.destroy(); |
