about summary refs log tree commit diff
path: root/editors/code/src
diff options
context:
space:
mode:
authorvsrs <vit@conrlab.com>2020-06-05 15:25:01 +0300
committervsrs <vit@conrlab.com>2020-06-05 15:25:01 +0300
commit78c9223b7bd4bffe64b7ec69e5fee08604dc0057 (patch)
treeab1770311871a80703fadb50f4fa05a09512e235 /editors/code/src
parent0fe43a124bb2b135cfd1268fda2941c3ac170c96 (diff)
downloadrust-78c9223b7bd4bffe64b7ec69e5fee08604dc0057.tar.gz
rust-78c9223b7bd4bffe64b7ec69e5fee08604dc0057.zip
Remove hover contents marking as trusted.
Hover contents might be extracted from raw
doc comments and need some validation.
Diffstat (limited to 'editors/code/src')
-rw-r--r--editors/code/src/client.ts17
1 files changed, 2 insertions, 15 deletions
diff --git a/editors/code/src/client.ts b/editors/code/src/client.ts
index f2094b5cefe..65ad573d8c9 100644
--- a/editors/code/src/client.ts
+++ b/editors/code/src/client.ts
@@ -7,20 +7,11 @@ import { CallHierarchyFeature } from 'vscode-languageclient/lib/callHierarchy.pr
 import { SemanticTokensFeature, DocumentSemanticsTokensSignature } from 'vscode-languageclient/lib/semanticTokens.proposed';
 import { assert } from './util';
 
-function toTrusted(obj: vscode.MarkedString): vscode.MarkedString {
-    const md = <vscode.MarkdownString>obj;
-    if (md && md.value.includes("```rust")) {
-        md.isTrusted = true;
-        return md;
-    }
-    return obj;
-}
-
-function renderCommand(cmd: CommandLink) {
+function renderCommand(cmd: ra.CommandLink) {
     return `[${cmd.title}](command:${cmd.command}?${encodeURIComponent(JSON.stringify(cmd.arguments))} '${cmd.tooltip!}')`;
 }
 
-function renderHoverActions(actions: CommandLinkGroup[]): vscode.MarkdownString {
+function renderHoverActions(actions: ra.CommandLinkGroup[]): vscode.MarkdownString {
     const text = actions.map(group =>
         (group.title ? (group.title + " ") : "") + group.commands.map(renderCommand).join(' | ')
     ).join('___');
@@ -63,10 +54,6 @@ export function createClient(serverPath: string, cwd: string): lc.LanguageClient
                     (result) => {
                         const hover = client.protocol2CodeConverter.asHover(result);
                         if (hover) {
-                            // Workaround to support command links (trusted vscode.MarkdownString) in hovers
-                            // https://github.com/microsoft/vscode/issues/33577
-                            hover.contents = hover.contents.map(toTrusted);
-
                             const actions = (<any>result).actions;
                             if (actions) {
                                 hover.contents.push(renderHoverActions(actions));