diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-11-08 13:37:34 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-11-08 13:37:34 +0000 |
| commit | f48b2622d8e4d2f91dc8ffa7f8708c7484dd4eb6 (patch) | |
| tree | f74f6ce2f2100d7ee8eb66361db9ff051851abe8 /editors/code | |
| parent | c5c11b87cc28a2bc63d6125f67732c3adfa09917 (diff) | |
| parent | 36bdb5c94d0eaf94e35145186ffc28c6f8f14bec (diff) | |
| download | rust-f48b2622d8e4d2f91dc8ffa7f8708c7484dd4eb6.tar.gz rust-f48b2622d8e4d2f91dc8ffa7f8708c7484dd4eb6.zip | |
Merge #10688
10688: internal: Type-check TS on CI and also turn off the strict setting `useUnknownInCatchVariables` r=lnicola a=ChayimFriedman2 We don't follow it and I found that turning it on will have little benefit. I'm not sure if we should also type-check when building in launch.json. Co-authored-by: Chayim Refael Friedman <chayimfr@gmail.com>
Diffstat (limited to 'editors/code')
| -rw-r--r-- | editors/code/package-lock.json | 14 | ||||
| -rw-r--r-- | editors/code/package.json | 2 | ||||
| -rw-r--r-- | editors/code/tsconfig.json | 1 |
3 files changed, 9 insertions, 8 deletions
diff --git a/editors/code/package-lock.json b/editors/code/package-lock.json index 0b226a985d5..e3372574b34 100644 --- a/editors/code/package-lock.json +++ b/editors/code/package-lock.json @@ -28,7 +28,7 @@ "glob": "^7.1.6", "mocha": "^9.0.2", "tslib": "^2.3.0", - "typescript": "^4.3.5", + "typescript": "^4.4.4", "typescript-formatter": "^7.2.2", "vsce": "^1.95.1", "vscode-test": "^1.5.1" @@ -3541,9 +3541,9 @@ } }, "node_modules/typescript": { - "version": "4.3.5", - "resolved": "https://registry.npmjs.org/typescript/-/typescript-4.3.5.tgz", - "integrity": "sha512-DqQgihaQ9cUrskJo9kIyW/+g0Vxsk8cDtZ52a3NGh0YNTfpUSArXSohyUGnvbPazEPLu398C0UxmKSOrPumUzA==", + "version": "4.4.4", + "resolved": "https://registry.npmjs.org/typescript/-/typescript-4.4.4.tgz", + "integrity": "sha512-DqGhF5IKoBl8WNf8C1gu8q0xZSInh9j1kJJMqT3a94w1JzVaBU4EXOSMrz9yDqMT0xt3selp83fuFMQ0uzv6qA==", "dev": true, "bin": { "tsc": "bin/tsc", @@ -6647,9 +6647,9 @@ } }, "typescript": { - "version": "4.3.5", - "resolved": "https://registry.npmjs.org/typescript/-/typescript-4.3.5.tgz", - "integrity": "sha512-DqQgihaQ9cUrskJo9kIyW/+g0Vxsk8cDtZ52a3NGh0YNTfpUSArXSohyUGnvbPazEPLu398C0UxmKSOrPumUzA==", + "version": "4.4.4", + "resolved": "https://registry.npmjs.org/typescript/-/typescript-4.4.4.tgz", + "integrity": "sha512-DqGhF5IKoBl8WNf8C1gu8q0xZSInh9j1kJJMqT3a94w1JzVaBU4EXOSMrz9yDqMT0xt3selp83fuFMQ0uzv6qA==", "dev": true }, "typescript-formatter": { diff --git a/editors/code/package.json b/editors/code/package.json index 336081e88c5..4c718f0b798 100644 --- a/editors/code/package.json +++ b/editors/code/package.json @@ -32,7 +32,7 @@ "watch": "npm run build-base -- --sourcemap --watch", "lint": "tsfmt --verify && eslint -c .eslintrc.js --ext ts ./src ./tests", "fix": " tsfmt -r && eslint -c .eslintrc.js --ext ts ./src ./tests --fix", - "pretest": "tsc && npm run build", + "pretest": "tsc --noEmit && npm run build", "test": "node ./out/tests/runTests.js" }, "dependencies": { diff --git a/editors/code/tsconfig.json b/editors/code/tsconfig.json index c9f348241a3..7c4fbd21ebe 100644 --- a/editors/code/tsconfig.json +++ b/editors/code/tsconfig.json @@ -9,6 +9,7 @@ "sourceMap": true, "rootDir": ".", "strict": true, + "useUnknownInCatchVariables": false, "noUnusedLocals": true, "noUnusedParameters": true, "noImplicitReturns": true, |