diff options
| author | Folkert de Vries <folkert@folkertdev.nl> | 2025-07-27 23:27:40 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-07-27 17:27:40 -0400 |
| commit | 9c683d3487d8966dad182bc7ad2524bf0bb6d797 (patch) | |
| tree | bf6ad0e319007035018ca281d3b0a7b19ef49da0 /library/compiler-builtins/libm-test/src/precision.rs | |
| parent | c061e73d9ff3fa07dcb005a40453e124302bdeb8 (diff) | |
| download | rust-9c683d3487d8966dad182bc7ad2524bf0bb6d797.tar.gz rust-9c683d3487d8966dad182bc7ad2524bf0bb6d797.zip | |
Implement `floor` and `ceil` in assembly on `i586`
Fixes: https://github.com/rust-lang/compiler-builtins/issues/837
The assembly is based on
- https://github.com/NetBSD/src/blob/20433927938987dd64c8f6aa46904b7aca3fa39e/lib/libm/arch/i387/s_floor.S
- https://github.com/NetBSD/src/blob/20433927938987dd64c8f6aa46904b7aca3fa39e/lib/libm/arch/i387/s_ceil.S
Which both state
/*
* Written by J.T. Conklin <jtc@NetBSD.org>.
* Public domain.
*/
Which I believe means we're good in terms of licensing.Diffstat (limited to 'library/compiler-builtins/libm-test/src/precision.rs')
| -rw-r--r-- | library/compiler-builtins/libm-test/src/precision.rs | 22 |
1 files changed, 0 insertions, 22 deletions
diff --git a/library/compiler-builtins/libm-test/src/precision.rs b/library/compiler-builtins/libm-test/src/precision.rs index 32825b15d47..3fb8c1b3710 100644 --- a/library/compiler-builtins/libm-test/src/precision.rs +++ b/library/compiler-builtins/libm-test/src/precision.rs @@ -272,18 +272,6 @@ impl MaybeOverride<(f32,)> for SpecialCase { impl MaybeOverride<(f64,)> for SpecialCase { fn check_float<F: Float>(input: (f64,), actual: F, expected: F, ctx: &CheckCtx) -> CheckAction { if cfg!(x86_no_sse) - && ctx.base_name == BaseName::Ceil - && ctx.basis == CheckBasis::Musl - && input.0 < 0.0 - && input.0 > -1.0 - && expected == F::ZERO - && actual == F::ZERO - { - // musl returns -0.0, we return +0.0 - return XFAIL("i586 ceil signed zero"); - } - - if cfg!(x86_no_sse) && (ctx.base_name == BaseName::Rint || ctx.base_name == BaseName::Roundeven) && (expected - actual).abs() <= F::ONE && (expected - actual).abs() > F::ZERO @@ -293,16 +281,6 @@ impl MaybeOverride<(f64,)> for SpecialCase { } if cfg!(x86_no_sse) - && (ctx.fn_ident == Identifier::Ceil || ctx.fn_ident == Identifier::Floor) - && expected.eq_repr(F::NEG_ZERO) - && actual.eq_repr(F::ZERO) - { - // FIXME: the x87 implementations do not keep the distinction between -0.0 and 0.0. - // See https://github.com/rust-lang/libm/pull/404#issuecomment-2572399955 - return XFAIL("i586 ceil/floor signed zero"); - } - - if cfg!(x86_no_sse) && (ctx.fn_ident == Identifier::Exp10 || ctx.fn_ident == Identifier::Exp2) { // FIXME: i586 has very imprecise results with ULP > u32::MAX for these |