about summary refs log tree commit diff
path: root/library/core/src/array
diff options
context:
space:
mode:
authorThe8472 <git@infinite-source.de>2021-10-11 23:36:04 +0200
committerThe8472 <git@infinite-source.de>2021-10-11 23:36:04 +0200
commitf1c588f1ef391b33663f44c52b17c9cc12928a75 (patch)
tree17d34b1c16308c256e91ce495f9a6e4a1f5c4e7a /library/core/src/array
parenta398b6b9d429cd0044c0b4cec95ec4fe2dbac295 (diff)
downloadrust-f1c588f1ef391b33663f44c52b17c9cc12928a75.tar.gz
rust-f1c588f1ef391b33663f44c52b17c9cc12928a75.zip
use fold instead of try_fold now that .by_ref().next() has been inlined
Diffstat (limited to 'library/core/src/array')
-rw-r--r--library/core/src/array/iter.rs19
1 files changed, 6 insertions, 13 deletions
diff --git a/library/core/src/array/iter.rs b/library/core/src/array/iter.rs
index 822747dd0e8..5d63cf03fcb 100644
--- a/library/core/src/array/iter.rs
+++ b/library/core/src/array/iter.rs
@@ -135,19 +135,12 @@ impl<T, const N: usize> Iterator for IntoIter<T, N> {
         Fold: FnMut(Acc, Self::Item) -> Acc,
     {
         let data = &mut self.data;
-        // FIXME: This uses try_fold(&mut iter) instead of fold(iter) because the latter
-        //  would go through the blanket `impl Iterator for &mut I` implementation
-        //  which lacks inline annotations on its methods and adding those would be a larger
-        //  perturbation than using try_fold here.
-        //  Whether it would be beneficial to add those annotations should be investigated separately.
-        (&mut self.alive)
-            .try_fold::<_, _, Result<_, !>>(init, |acc, idx| {
-                // SAFETY: idx is obtained by folding over the `alive` range, which implies the
-                // value is currently considered alive but as the range is being consumed each value
-                // we read here will only be read once and then considered dead.
-                Ok(fold(acc, unsafe { data.get_unchecked(idx).assume_init_read() }))
-            })
-            .unwrap()
+        self.alive.by_ref().fold(init, |acc, idx| {
+            // SAFETY: idx is obtained by folding over the `alive` range, which implies the
+            // value is currently considered alive but as the range is being consumed each value
+            // we read here will only be read once and then considered dead.
+            fold(acc, unsafe { data.get_unchecked(idx).assume_init_read() })
+        })
     }
 
     fn count(self) -> usize {