diff options
| author | bors <bors@rust-lang.org> | 2023-06-10 12:47:51 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2023-06-10 12:47:51 +0000 |
| commit | 788c98df5995c9fe360ba9ba5efb103ee69d05c4 (patch) | |
| tree | 899ba7b18bc831fbfb002da17a22bd6dccf37050 /library/core | |
| parent | 4b71d79c972a605959b0a7c82b323fbd8562f070 (diff) | |
| parent | a8145372d70f0aeee27546219bdc9564420cc974 (diff) | |
| download | rust-788c98df5995c9fe360ba9ba5efb103ee69d05c4.tar.gz rust-788c98df5995c9fe360ba9ba5efb103ee69d05c4.zip | |
Auto merge of #111818 - Urgau:uplift_cmp_nan, r=cjgillot
Uplift `clippy::cmp_nan` lint
This PR aims at uplifting the `clippy::cmp_nan` lint into rustc.
## `invalid_nan_comparisons`
~~(deny-by-default)~~ (warn-by-default)
The `invalid_nan_comparisons` lint checks comparison with `f32::NAN` or `f64::NAN` as one of the operand.
### Example
```rust,compile_fail
let a = 2.3f32;
if a == f32::NAN {}
```
### Explanation
NaN does not compare meaningfully to anything – not even itself – so those comparisons are always false.
-----
Mostly followed the instructions for uplifting a clippy lint described here: https://github.com/rust-lang/rust/pull/99696#pullrequestreview-1134072751
`@rustbot` label: +I-lang-nominated
r? compiler
Diffstat (limited to 'library/core')
| -rw-r--r-- | library/core/src/num/f32.rs | 1 | ||||
| -rw-r--r-- | library/core/src/num/f64.rs | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/library/core/src/num/f32.rs b/library/core/src/num/f32.rs index 4a035ad61e1..d050d21c8c5 100644 --- a/library/core/src/num/f32.rs +++ b/library/core/src/num/f32.rs @@ -403,6 +403,7 @@ impl f32 { /// and the stability of its representation over Rust versions /// and target platforms isn't guaranteed. #[stable(feature = "assoc_int_consts", since = "1.43.0")] + #[rustc_diagnostic_item = "f32_nan"] pub const NAN: f32 = 0.0_f32 / 0.0_f32; /// Infinity (∞). #[stable(feature = "assoc_int_consts", since = "1.43.0")] diff --git a/library/core/src/num/f64.rs b/library/core/src/num/f64.rs index 3aafc435f1e..d9a738191f7 100644 --- a/library/core/src/num/f64.rs +++ b/library/core/src/num/f64.rs @@ -401,6 +401,7 @@ impl f64 { /// This constant isn't guaranteed to equal to any specific NaN bitpattern, /// and the stability of its representation over Rust versions /// and target platforms isn't guaranteed. + #[rustc_diagnostic_item = "f64_nan"] #[stable(feature = "assoc_int_consts", since = "1.43.0")] pub const NAN: f64 = 0.0_f64 / 0.0_f64; /// Infinity (∞). |