diff options
| author | John Kåre Alsaker <john.kare.alsaker@gmail.com> | 2024-03-22 16:01:31 +0100 |
|---|---|---|
| committer | John Kåre Alsaker <john.kare.alsaker@gmail.com> | 2024-03-22 16:21:26 +0100 |
| commit | c2e5ee40b699608128654f2b67e0fafa8e1ec8dc (patch) | |
| tree | 08cab4fb8ea11088afbb5c34f3ae8befaff6c121 /library/std/src/io/stdio.rs | |
| parent | eff958c59e8c07ba0515e164b825c9001b242294 (diff) | |
| download | rust-c2e5ee40b699608128654f2b67e0fafa8e1ec8dc.tar.gz rust-c2e5ee40b699608128654f2b67e0fafa8e1ec8dc.zip | |
Avoid a panic in `set_output_capture` in the default panic handler
Diffstat (limited to 'library/std/src/io/stdio.rs')
| -rw-r--r-- | library/std/src/io/stdio.rs | 24 |
1 files changed, 22 insertions, 2 deletions
diff --git a/library/std/src/io/stdio.rs b/library/std/src/io/stdio.rs index 8f60b3b1535..cb55d488b0c 100644 --- a/library/std/src/io/stdio.rs +++ b/library/std/src/io/stdio.rs @@ -15,6 +15,7 @@ use crate::panic::{RefUnwindSafe, UnwindSafe}; use crate::sync::atomic::{AtomicBool, Ordering}; use crate::sync::{Arc, Mutex, MutexGuard, OnceLock, ReentrantLock, ReentrantLockGuard}; use crate::sys::stdio; +use crate::thread::AccessError; type LocalStream = Arc<Mutex<Vec<u8>>>; @@ -1054,12 +1055,31 @@ impl fmt::Debug for StderrLock<'_> { )] #[doc(hidden)] pub fn set_output_capture(sink: Option<LocalStream>) -> Option<LocalStream> { + try_set_output_capture(sink).expect( + "cannot access a Thread Local Storage value \ + during or after destruction", + ) +} + +/// Tries to set the thread-local output capture buffer and returns the old one. +/// This may fail once thread-local destructors are called. It's used in panic +/// handling instead of `set_output_capture`. +#[unstable( + feature = "internal_output_capture", + reason = "this function is meant for use in the test crate \ + and may disappear in the future", + issue = "none" +)] +#[doc(hidden)] +pub fn try_set_output_capture( + sink: Option<LocalStream>, +) -> Result<Option<LocalStream>, AccessError> { if sink.is_none() && !OUTPUT_CAPTURE_USED.load(Ordering::Relaxed) { // OUTPUT_CAPTURE is definitely None since OUTPUT_CAPTURE_USED is false. - return None; + return Ok(None); } OUTPUT_CAPTURE_USED.store(true, Ordering::Relaxed); - OUTPUT_CAPTURE.with(move |slot| slot.replace(sink)) + OUTPUT_CAPTURE.try_with(move |slot| slot.replace(sink)) } /// Write `args` to the capture buffer if enabled and possible, or `global_s` |
