about summary refs log tree commit diff
path: root/library/std/src/sys/unix/kernel_copy.rs
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2021-07-02 09:01:42 +0000
committerbors <bors@rust-lang.org>2021-07-02 09:01:42 +0000
commitf9fa13f705bb8b1c57c6b6fe95055ec4995a40f0 (patch)
treebbb013fe0b9af5703ce1a04f75d6435d61f473ad /library/std/src/sys/unix/kernel_copy.rs
parent1aa6c7cbc6d2582e7407cde9c65014aef8a189bb (diff)
parentcc907330083a18a9067664c1db3db1959f58d00c (diff)
downloadrust-f9fa13f705bb8b1c57c6b6fe95055ec4995a40f0.tar.gz
rust-f9fa13f705bb8b1c57c6b6fe95055ec4995a40f0.zip
Auto merge of #85746 - m-ou-se:io-error-other, r=joshtriplett
Redefine `ErrorKind::Other` and stop using it in std.

This implements the idea I shared yesterday in the libs meeting when we were discussing how to handle adding new `ErrorKind`s to the standard library: This redefines `Other` to be for *user defined errors only*, and changes all uses of `Other` in the standard library to a `#[doc(hidden)]` and permanently `#[unstable]` `ErrorKind` that users can not match on. This ensures that adding `ErrorKind`s at a later point in time is not a breaking change, since the user couldn't match on these errors anyway. This way, we use the `#[non_exhaustive]` property of the enum in a more effective way.

Open questions:
- How do we check this change doesn't cause too much breakage? Will a crate run help and be enough?
- How do we ensure we don't accidentally start using `Other` again in the standard library? We don't have a `pub(not crate)` or `#[deprecated(in this crate only)]`.

cc https://github.com/rust-lang/rust/pull/79965

cc `@rust-lang/libs` `@ijackson`

r? `@dtolnay`
Diffstat (limited to 'library/std/src/sys/unix/kernel_copy.rs')
0 files changed, 0 insertions, 0 deletions