diff options
| author | Yuki Okushi <huyuumi.dev@gmail.com> | 2021-02-22 18:26:07 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-02-22 18:26:07 +0900 |
| commit | 20c1fa17707e6cdd202a9a720f7dfe0000ecb74e (patch) | |
| tree | 5788c32fcd4a3e0979bdfee4937121731566906d /library/std/src/sys/unix/stack_overflow.rs | |
| parent | a5f66689203cff8f96f110bf10926c2d911f6811 (diff) | |
| parent | 447ce2719810f7654bb3e5a3d20fb459bb191547 (diff) | |
| download | rust-20c1fa17707e6cdd202a9a720f7dfe0000ecb74e.tar.gz rust-20c1fa17707e6cdd202a9a720f7dfe0000ecb74e.zip | |
Rollup merge of #82287 - r00ster91:field_name_and, r=petrochenkov
Make "missing field" error message more natural
```rust
struct A {
x: i32,
y: i32,
z: i32,
}
fn main() {
A { };
}
```
```
error[E0063]: missing fields `x`, `y`, `z` in initializer of `A`
--> src/main.rs:8:5
|
8 | A { };
| ^ missing `x`, `y`, `z`
```
This error is now:
```
error[E0063]: missing fields `x`, `y` and `z` in initializer of `A`
--> src/main.rs:8:5
|
8 | A { };
| ^ missing `x`, `y` and `z`
```
I thought it looked nicer and more natural this way. Also, if there is >3 fields missing, there is an "and" as well ("missing \`x\`, \`y\`, \`z\` *and* 1 other field"), but for <=3 there is not. As such it improves consistency too.
As for the implementation, originally I ended up with a chunky `push_str` algorithm but then I figured I could just do the formatting manually since it's just 3 field names at maximum. It is comparatively readable.
As a sidenote, one thing I was wondering about is, isn't there more cases where you have a list of things like field names? Maybe this whole thing can at some point later be made into a more general function to be used in multiple areas.
Diffstat (limited to 'library/std/src/sys/unix/stack_overflow.rs')
0 files changed, 0 insertions, 0 deletions
