about summary refs log tree commit diff
path: root/library/std/src/sys/unix/stack_overflow.rs
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2022-03-02 03:03:22 +0000
committerbors <bors@rust-lang.org>2022-03-02 03:03:22 +0000
commit7df92e44c0d13caf1b42099482585e6ab8f5adca (patch)
tree2b7c3c87e9dcd073f0b31f07d797c293d0b621f2 /library/std/src/sys/unix/stack_overflow.rs
parent962b8cf38b2d0db3b827f978d777eec2ce656b42 (diff)
parent4f132cb340c3fdcaedf42a59c6f72f901effe5f4 (diff)
downloadrust-7df92e44c0d13caf1b42099482585e6ab8f5adca.tar.gz
rust-7df92e44c0d13caf1b42099482585e6ab8f5adca.zip
Auto merge of #87402 - nagisa:nagisa/request-feature-requests-for-features, r=estebank
Direct users towards using Rust target feature names in CLI

This PR consists of a couple of changes on how we handle target features.

In particular there is a bug-fix wherein we avoid passing through features that aren't prefixed by `+` or `-` to LLVM. These appear to be causing LLVM to assert, which is pretty poor a behaviour (and also makes it pretty clear we expect feature names to be prefixed).

The other commit, I anticipate to be somewhat more controversial is outputting a warning when users specify a LLVM-specific, or otherwise unknown, feature name on the CLI. In those situations we request users to either replace it with a known Rust feature name (e.g. `bmi` -> `bmi1`) or file a feature request. I've a couple motivations for this: first of all, if users are specifying these features on the command line, I'm pretty confident there is also a need for these features to be usable via `#[cfg(target_feature)]` machinery.  And second, we're growing a fair number of backends recently and having ability to provide some sort of unified-ish interface in this place seems pretty useful to me.

Sponsored by: standard.ai
Diffstat (limited to 'library/std/src/sys/unix/stack_overflow.rs')
0 files changed, 0 insertions, 0 deletions