about summary refs log tree commit diff
path: root/library/std/src
diff options
context:
space:
mode:
authorMatthias Krüger <476013+matthiaskrgr@users.noreply.github.com>2025-03-07 10:02:19 +0100
committerGitHub <noreply@github.com>2025-03-07 10:02:19 +0100
commit0b151c6c4fa8dfb458afd36da8418be02a3b1b10 (patch)
tree1ec1c4ee51dcad19d92743aa63dde5e249fbfeca /library/std/src
parent91a0e1604f343730022bc903cbf201d8b0a86a71 (diff)
parent93ef8089afa10c86a03627f6f3291451343f28e6 (diff)
downloadrust-0b151c6c4fa8dfb458afd36da8418be02a3b1b10.tar.gz
rust-0b151c6c4fa8dfb458afd36da8418be02a3b1b10.zip
Rollup merge of #136667 - vita-rust:revert-vita-c-char, r=cuviper
Revert vita's c_char back to i8

# Description

Hi!

https://github.com/rust-lang/rust/pull/132975 changed the definition of `c_char` from i8 to u8 for most ARM targets. While that would usually be correct, [VITASDK uses signed chars by default](https://github.com/vitasdk/buildscripts/blob/master/patches/gcc/0001-gcc-10.patch#L33-L34). The Clang definitions are incorrect because Clang is not (yet?) supported by the vita commmunity / `VITADSK`, On the Rust side, the pre-compiled libraries the user can link to are all compiled using vita's `gcc` and [we set `TARGET_CC` and `TARGET_CXX`](https://github.com/vita-rust/cargo-vita/blob/d564a132cbd43947118c0d6d0ebfbea7d1dd7fa7/src/commands/build.rs#L230) in `cargo vita` for build scripts using `cc`.

I'm creating it as a draft PR so that we can discuss it and possibly get it approved here, but wait to merge the [libc side](https://github.com/rust-lang/libc/pull/4258) and get a libc version first, as having the definitions out of sync breaks std. As a nightly-only target it can be confusing/frustrating for new users when the latest nightly, which is the default, is broken.
Diffstat (limited to 'library/std/src')
0 files changed, 0 insertions, 0 deletions