diff options
| author | bors <bors@rust-lang.org> | 2020-08-26 18:40:51 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2020-08-26 18:40:51 +0000 |
| commit | 48717b6f3ce661d2a0d64f7bdfdfb5fd3484ee5b (patch) | |
| tree | 6132a4164c89982923e6303d7f39373f2ae46efa /library/std/src | |
| parent | 1f2dd3b56aec4d8f97eb0b0552c166ef549d3316 (diff) | |
| parent | f3024073f92b15d38b42241e65067f0ba796896c (diff) | |
| download | rust-48717b6f3ce661d2a0d64f7bdfdfb5fd3484ee5b.tar.gz rust-48717b6f3ce661d2a0d64f7bdfdfb5fd3484ee5b.zip | |
Auto merge of #75912 - scottmcm:manuallydrop-vs-forget, r=Mark-Simulacrum
Suggest `mem::forget` if `mem::ManuallyDrop::new` isn't used I think this communicates the intent more idiomatically, and is shorter anyway. Inspired because [it came up on URLO](https://users.rust-lang.org/t/validity-of-memory-area-after-std-forget/47730/7?u=scottmcm), and it turns out that std had done it too in one spot: 
Diffstat (limited to 'library/std/src')
| -rw-r--r-- | library/std/src/lazy.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/library/std/src/lazy.rs b/library/std/src/lazy.rs index f0548582d2f..d0f27df5185 100644 --- a/library/std/src/lazy.rs +++ b/library/std/src/lazy.rs @@ -293,7 +293,7 @@ impl<T> SyncOnceCell<T> { // Don't drop this `SyncOnceCell`. We just moved out one of the fields, but didn't set // the state to uninitialized. - mem::ManuallyDrop::new(self); + mem::forget(self); inner } |
