diff options
| author | Chris Denton <chris@chrisdenton.dev> | 2023-11-21 23:06:35 +0000 |
|---|---|---|
| committer | Chris Denton <chris@chrisdenton.dev> | 2023-11-22 13:00:28 +0000 |
| commit | bfbeb3ebd977997233f93c5cce11bbdfdd34237d (patch) | |
| tree | 0235edce89bf6ef34fa6b945939000fb5d8940e5 /library/std/src | |
| parent | 6c22e57c39b8fd8304ad317b42ddb7561000215f (diff) | |
| download | rust-bfbeb3ebd977997233f93c5cce11bbdfdd34237d.tar.gz rust-bfbeb3ebd977997233f93c5cce11bbdfdd34237d.zip | |
unnecessary_mut_passed
This is where our Windows API bindings previously (and incorrectly) used `*mut` instead of `*const` pointers. Now that the bindings have been corrected, the mutable references (which auto-convert to `*mut`) are unnecessary and we can use shared references.
Diffstat (limited to 'library/std/src')
| -rw-r--r-- | library/std/src/os/windows/io/socket.rs | 4 | ||||
| -rw-r--r-- | library/std/src/sys/windows/fs.rs | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/library/std/src/os/windows/io/socket.rs b/library/std/src/os/windows/io/socket.rs index c80b9e28499..65f161f32e7 100644 --- a/library/std/src/os/windows/io/socket.rs +++ b/library/std/src/os/windows/io/socket.rs @@ -127,7 +127,7 @@ impl BorrowedSocket<'_> { info.iAddressFamily, info.iSocketType, info.iProtocol, - &mut info, + &info, 0, sys::c::WSA_FLAG_OVERLAPPED | sys::c::WSA_FLAG_NO_HANDLE_INHERIT, ) @@ -147,7 +147,7 @@ impl BorrowedSocket<'_> { info.iAddressFamily, info.iSocketType, info.iProtocol, - &mut info, + &info, 0, sys::c::WSA_FLAG_OVERLAPPED, ) diff --git a/library/std/src/sys/windows/fs.rs b/library/std/src/sys/windows/fs.rs index d7e36b9a3ff..4deda6d97c4 100644 --- a/library/std/src/sys/windows/fs.rs +++ b/library/std/src/sys/windows/fs.rs @@ -786,7 +786,7 @@ fn open_link_no_reparse(parent: &File, name: &[u16], access: u32) -> io::Result< // tricked into following a symlink. However, it may not be available in // earlier versions of Windows. static ATTRIBUTES: AtomicU32 = AtomicU32::new(c::OBJ_DONT_REPARSE); - let mut object = c::OBJECT_ATTRIBUTES { + let object = c::OBJECT_ATTRIBUTES { ObjectName: &mut name_str, RootDirectory: parent.as_raw_handle(), Attributes: ATTRIBUTES.load(Ordering::Relaxed), @@ -795,7 +795,7 @@ fn open_link_no_reparse(parent: &File, name: &[u16], access: u32) -> io::Result< let status = c::NtCreateFile( &mut handle, access, - &mut object, + &object, &mut io_status, crate::ptr::null_mut(), 0, |