about summary refs log tree commit diff
path: root/library/std/src
diff options
context:
space:
mode:
authorChristiaan Dirkx <christiaan@dirkx.email>2021-04-14 14:03:00 +0200
committerChristiaan Dirkx <christiaan@dirkx.email>2021-04-14 14:03:00 +0200
commitcac0dd63b3514569ce79480b0cdf92335c5cf9f4 (patch)
tree913d6ab98b2a76837ce979a6e232130269f8faf0 /library/std/src
parent905d23b65c07a1da4452f9a20b1891fc46533fb7 (diff)
downloadrust-cac0dd63b3514569ce79480b0cdf92335c5cf9f4.tar.gz
rust-cac0dd63b3514569ce79480b0cdf92335c5cf9f4.zip
Update documentation
Diffstat (limited to 'library/std/src')
-rw-r--r--library/std/src/sys/common/alloc.rs2
-rw-r--r--library/std/src/sys/common/mod.rs12
-rw-r--r--library/std/src/sys_common/mod.rs8
3 files changed, 17 insertions, 5 deletions
diff --git a/library/std/src/sys/common/alloc.rs b/library/std/src/sys/common/alloc.rs
index 6c1bc0d839a..2a54e99020e 100644
--- a/library/std/src/sys/common/alloc.rs
+++ b/library/std/src/sys/common/alloc.rs
@@ -1,5 +1,3 @@
-#![allow(dead_code)]
-
 use crate::alloc::{GlobalAlloc, Layout, System};
 use crate::cmp;
 use crate::ptr;
diff --git a/library/std/src/sys/common/mod.rs b/library/std/src/sys/common/mod.rs
index 920965d5944..ff64d2aa825 100644
--- a/library/std/src/sys/common/mod.rs
+++ b/library/std/src/sys/common/mod.rs
@@ -1 +1,13 @@
+// This module contains code that is shared between all platforms, mostly utility or fallback code.
+// This explicitly does not include code that is shared between only a few platforms,
+// such as when reusing an implementation from `unix` or `unsupported`.
+// In those cases the desired code should be included directly using the #[path] attribute,
+// not moved to this module.
+//
+// Currently `sys_common` contains a lot of code that should live in this module,
+// ideally `sys_common` would only contain platform-independent abstractions on top of `sys`.
+// Progress on this is tracked in #84187.
+
+#![allow(dead_code)]
+
 pub mod alloc;
diff --git a/library/std/src/sys_common/mod.rs b/library/std/src/sys_common/mod.rs
index 9700d1f6daa..23a3a0e907d 100644
--- a/library/std/src/sys_common/mod.rs
+++ b/library/std/src/sys_common/mod.rs
@@ -8,9 +8,11 @@
 //! rest of `std` is complex, with dependencies going in all
 //! directions: `std` depending on `sys_common`, `sys_common`
 //! depending on `sys`, and `sys` depending on `sys_common` and `std`.
-//! Ideally `sys_common` would be split into two and the dependencies
-//! between them all would form a dag, facilitating the extraction of
-//! `std::sys` from the standard library.
+//! This is because `sys_common` not only contains platform-independent code,
+//! but also code that is shared between the different platforms in `sys`.
+//! Ideally all that shared code should be moved to `sys::common`,
+//! and the dependencies between `std`, `sys_common` and `sys` all would form a dag.
+//! Progress on this is tracked in #84187.
 
 #![allow(missing_docs)]
 #![allow(missing_debug_implementations)]