about summary refs log tree commit diff
path: root/library/std/src
diff options
context:
space:
mode:
authorSasha <sasha.pourcelot@protonmail.com>2020-08-28 23:04:42 +0200
committerSasha <sasha.pourcelot@protonmail.com>2020-08-30 22:09:58 +0200
commitf6d18db402cfebcf5c1bdc8e730f3923b3bb0421 (patch)
tree75a6755f7e97b1a5e7da581a8361ee65193b6b25 /library/std/src
parent85fbf49ce0e2274d0acf798f6e703747674feec3 (diff)
downloadrust-f6d18db402cfebcf5c1bdc8e730f3923b3bb0421.tar.gz
rust-f6d18db402cfebcf5c1bdc8e730f3923b3bb0421.zip
Use string literal directly when available in format
Previous implementation used the `Parser::parse_expr` function in order
to extract the format expression. If the first comma following the
format expression was mistakenly replaced with a dot, then the next
format expression was eaten by the function, because it looked as a
syntactically valid expression, which resulted in incorrectly spanned
error messages.

The way the format expression is exctracted is changed: we first look at
the first available token in the first argument supplied to the
`format!` macro call. If it is a string literal, then it is promoted as
a format expression immediatly, otherwise we fall back to the original
`parse_expr`-related method.

This allows us to ensure that the parser won't consume too much tokens
when a typo is made.

A test has been created so that it is ensured that the issue is properly
fixed.
Diffstat (limited to 'library/std/src')
0 files changed, 0 insertions, 0 deletions