diff options
| author | Josh Triplett <josh@joshtriplett.org> | 2025-01-07 14:12:07 +0200 | 
|---|---|---|
| committer | Josh Triplett <josh@joshtriplett.org> | 2025-01-07 14:30:02 +0200 | 
| commit | bb6bbfa13f97e6ef30ecd63c835c99cf7762bd6e (patch) | |
| tree | 72903e70f117fddc546a875d4fff4285c11c00d1 /library/std | |
| parent | fb546ee09b226bc4dd4b712d35a372d923c4fa54 (diff) | |
| download | rust-bb6bbfa13f97e6ef30ecd63c835c99cf7762bd6e.tar.gz rust-bb6bbfa13f97e6ef30ecd63c835c99cf7762bd6e.zip | |
Avoid naming variables `str`
This renames variables named `str` to other names, to make sure `str` always refers to a type. It's confusing to read code where `str` (or another standard type name) is used as an identifier. It also produces misleading syntax highlighting.
Diffstat (limited to 'library/std')
| -rw-r--r-- | library/std/src/process.rs | 4 | ||||
| -rw-r--r-- | library/std/src/sys/pal/windows/process.rs | 6 | ||||
| -rw-r--r-- | library/std/src/sys_common/wtf8.rs | 4 | 
3 files changed, 7 insertions, 7 deletions
| diff --git a/library/std/src/process.rs b/library/std/src/process.rs index 929d2b57afe..4ad31dfd935 100644 --- a/library/std/src/process.rs +++ b/library/std/src/process.rs @@ -1283,13 +1283,13 @@ impl fmt::Debug for Output { fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result { let stdout_utf8 = str::from_utf8(&self.stdout); let stdout_debug: &dyn fmt::Debug = match stdout_utf8 { - Ok(ref str) => str, + Ok(ref s) => s, Err(_) => &self.stdout, }; let stderr_utf8 = str::from_utf8(&self.stderr); let stderr_debug: &dyn fmt::Debug = match stderr_utf8 { - Ok(ref str) => str, + Ok(ref s) => s, Err(_) => &self.stderr, }; diff --git a/library/std/src/sys/pal/windows/process.rs b/library/std/src/sys/pal/windows/process.rs index 2ca20a21dfe..9332c9b49ff 100644 --- a/library/std/src/sys/pal/windows/process.rs +++ b/library/std/src/sys/pal/windows/process.rs @@ -142,11 +142,11 @@ impl AsRef<OsStr> for EnvKey { } } -pub(crate) fn ensure_no_nuls<T: AsRef<OsStr>>(str: T) -> io::Result<T> { - if str.as_ref().encode_wide().any(|b| b == 0) { +pub(crate) fn ensure_no_nuls<T: AsRef<OsStr>>(s: T) -> io::Result<T> { + if s.as_ref().encode_wide().any(|b| b == 0) { Err(io::const_error!(ErrorKind::InvalidInput, "nul byte found in provided data")) } else { - Ok(str) + Ok(s) } } diff --git a/library/std/src/sys_common/wtf8.rs b/library/std/src/sys_common/wtf8.rs index 666942bb8a1..6c60d901ee9 100644 --- a/library/std/src/sys_common/wtf8.rs +++ b/library/std/src/sys_common/wtf8.rs @@ -204,8 +204,8 @@ impl Wtf8Buf { /// /// Since WTF-8 is a superset of UTF-8, this always succeeds. #[inline] - pub fn from_str(str: &str) -> Wtf8Buf { - Wtf8Buf { bytes: <[_]>::to_vec(str.as_bytes()), is_known_utf8: true } + pub fn from_str(s: &str) -> Wtf8Buf { + Wtf8Buf { bytes: <[_]>::to_vec(s.as_bytes()), is_known_utf8: true } } pub fn clear(&mut self) { | 
