diff options
| author | bors <bors@rust-lang.org> | 2018-07-29 09:33:37 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2018-07-29 09:33:37 +0000 |
| commit | 023fd7e74a9eb5bafcb75fcbe69b7110e9de4492 (patch) | |
| tree | c9b50228b27509d45f6d73e33aaec6b482c80c36 /src/bootstrap | |
| parent | a5c2d0fffaaf0b764c01bc4066e51ffd475ceae9 (diff) | |
| parent | 57a5a9b05423c4f832cd9a3aaa7e06d55fab6efa (diff) | |
Auto merge of #52767 - ljedrz:avoid_format, r=petrochenkov
Prefer to_string() to format!() Simple benchmarks suggest in some cases it can be faster by even 37%: ``` test converting_f64_long ... bench: 339 ns/iter (+/- 199) test converting_f64_short ... bench: 136 ns/iter (+/- 34) test converting_i32_long ... bench: 87 ns/iter (+/- 16) test converting_i32_short ... bench: 87 ns/iter (+/- 49) test converting_str ... bench: 54 ns/iter (+/- 15) test formatting_f64_long ... bench: 349 ns/iter (+/- 176) test formatting_f64_short ... bench: 145 ns/iter (+/- 14) test formatting_i32_long ... bench: 98 ns/iter (+/- 14) test formatting_i32_short ... bench: 93 ns/iter (+/- 15) test formatting_str ... bench: 86 ns/iter (+/- 23) ```
Diffstat (limited to 'src/bootstrap')
| -rw-r--r-- | src/bootstrap/builder.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/bootstrap/builder.rs b/src/bootstrap/builder.rs index c67787b5b0a..724d3b74190 100644 --- a/src/bootstrap/builder.rs +++ b/src/bootstrap/builder.rs @@ -925,7 +925,7 @@ impl<'a> Builder<'a> { cargo.env("RUSTC_VERIFY_LLVM_IR", "1"); } - cargo.env("RUSTC_VERBOSE", format!("{}", self.verbosity)); + cargo.env("RUSTC_VERBOSE", self.verbosity.to_string()); // in std, we want to avoid denying warnings for stage 0 as that makes cfg's painful. if self.config.deny_warnings && !(mode == Mode::Std && stage == 0) { |