diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2023-06-26 11:58:46 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-26 11:58:46 +0200 |
| commit | 5122e88b35dbf4e959d6ca2cfca4c5ed0a105203 (patch) | |
| tree | 458da839686b520435e30716c7652dfe7adacf41 /src/bootstrap | |
| parent | 005d860fc60ceb9fcc2981a13e05c55fa3ab1135 (diff) | |
| parent | bd36f636cb967a46b6d8d2f93f5f5a9f3bb85fad (diff) | |
| download | rust-5122e88b35dbf4e959d6ca2cfca4c5ed0a105203.tar.gz rust-5122e88b35dbf4e959d6ca2cfca4c5ed0a105203.zip | |
Rollup merge of #113034 - jyn514:ci-progress, r=oli-obk
Switch some more Steps to `builder.msg` In particular, this hides compiletest suites under a dropdown - some builders are configured with `verbose-tests`, which makes the suites take up many thousands of lines. before: ``` Documenting stage1 cargo (x86_64-unknown-linux-gnu) Check compiletest suite=rustdoc-js mode=js-doc-test (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu) ``` after: ``` ::group::Documenting stage1 cargo (x86_64-unknown-linux-gnu) ::group::Testing stage1 compiletest suite=rustdoc-js mode=js-doc-test (x86_64-unknown-linux-gnu) ``` found this from https://github.com/rust-lang-ci/rust/actions/runs/5366993848/jobs/9736792611 r? `@oli-obk`
Diffstat (limited to 'src/bootstrap')
| -rw-r--r-- | src/bootstrap/doc.rs | 15 | ||||
| -rw-r--r-- | src/bootstrap/lib.rs | 9 | ||||
| -rw-r--r-- | src/bootstrap/test.rs | 12 |
3 files changed, 20 insertions, 16 deletions
diff --git a/src/bootstrap/doc.rs b/src/bootstrap/doc.rs index 8592895423e..1ac52dffe58 100644 --- a/src/bootstrap/doc.rs +++ b/src/bootstrap/doc.rs @@ -222,7 +222,7 @@ impl Step for TheBook { let shared_assets = builder.ensure(SharedAssets { target }); // build the redirect pages - builder.info(&format!("Documenting book redirect pages ({})", target)); + builder.msg_doc(compiler, "book redirect pages", target); for file in t!(fs::read_dir(builder.src.join(&relative_path).join("redirects"))) { let file = t!(file); let path = file.path(); @@ -306,7 +306,7 @@ impl Step for Standalone { fn run(self, builder: &Builder<'_>) { let target = self.target; let compiler = self.compiler; - builder.info(&format!("Documenting standalone ({})", target)); + builder.msg_doc(compiler, "standalone", target); let out = builder.doc_out(target); t!(fs::create_dir_all(&out)); @@ -562,7 +562,7 @@ fn doc_std( let description = format!("library{} in {} format", crate_description(&requested_crates), format.as_str()); - let _guard = builder.msg(Kind::Doc, stage, &description, compiler.host, target); + let _guard = builder.msg_doc(compiler, &description, target); let target_doc_dir_name = if format == DocumentationFormat::JSON { "json-doc" } else { "doc" }; let target_dir = @@ -804,14 +804,7 @@ macro_rules! tool_doc { SourceType::Submodule }; - builder.info( - &format!( - "Documenting stage{} {} ({})", - stage, - stringify!($tool).to_lowercase(), - target, - ), - ); + builder.msg_doc(compiler, stringify!($tool).to_lowercase(), target); // Symlink compiler docs to the output directory of rustdoc documentation. let out_dirs = [ diff --git a/src/bootstrap/lib.rs b/src/bootstrap/lib.rs index d389b568f56..c960053d7a0 100644 --- a/src/bootstrap/lib.rs +++ b/src/bootstrap/lib.rs @@ -1009,6 +1009,15 @@ impl Build { self.msg(Kind::Check, self.config.stage, what, self.config.build, target) } + fn msg_doc( + &self, + compiler: Compiler, + what: impl Display, + target: impl Into<Option<TargetSelection>> + Copy, + ) -> Option<gha::Group> { + self.msg(Kind::Doc, compiler.stage, what, compiler.host, target.into()) + } + fn msg_build( &self, compiler: Compiler, diff --git a/src/bootstrap/test.rs b/src/bootstrap/test.rs index bdc6b4de6cd..ec447a1cd73 100644 --- a/src/bootstrap/test.rs +++ b/src/bootstrap/test.rs @@ -1832,11 +1832,13 @@ note: if you're sure you want to do this, please open an issue as to why. In the builder, ); - builder.info(&format!( - "Check compiletest suite={} mode={} ({} -> {})", - suite, mode, &compiler.host, target - )); - let _time = util::timeit(&builder); + let _group = builder.msg( + Kind::Test, + compiler.stage, + &format!("compiletest suite={suite} mode={mode}"), + compiler.host, + target, + ); crate::render_tests::try_run_tests(builder, &mut cmd, false); if let Some(compare_mode) = compare_mode { |
