about summary refs log tree commit diff
path: root/src/bootstrap
diff options
context:
space:
mode:
authorMateusz Mikuła <matti@marinelayer.io>2019-01-28 18:40:47 +0100
committerMateusz Mikuła <mati865@gmail.com>2019-01-28 21:57:40 +0100
commit99d00c86f85e8c1a7a1ba4cbe23d2e6b0ce85271 (patch)
treeaf782963f94d7954473f7fb107d3c855f791319f /src/bootstrap
parentd8a0dd7ae88023bd09fa4b86c9ca1f6ed8095b43 (diff)
downloadrust-99d00c86f85e8c1a7a1ba4cbe23d2e6b0ce85271.tar.gz
rust-99d00c86f85e8c1a7a1ba4cbe23d2e6b0ce85271.zip
bootstrap: set toolchain variables on per target basis
Using CC, CFLAGS, CXX, CXXFLAGS, AR and RANLIB breaks cross compilation
because host is built first and has correct values. The same
values are incorrect for the target however.
Diffstat (limited to 'src/bootstrap')
-rw-r--r--src/bootstrap/builder.rs13
1 files changed, 4 insertions, 9 deletions
diff --git a/src/bootstrap/builder.rs b/src/bootstrap/builder.rs
index f742bce180c..716774632a0 100644
--- a/src/bootstrap/builder.rs
+++ b/src/bootstrap/builder.rs
@@ -1051,29 +1051,24 @@ impl<'a> Builder<'a> {
                 }
             };
             let cc = ccacheify(&self.cc(target));
-            cargo.env(format!("CC_{}", target), &cc).env("CC", &cc);
+            cargo.env(format!("CC_{}", target), &cc);
 
             let cflags = self.cflags(target, GitRepo::Rustc).join(" ");
             cargo
-                .env(format!("CFLAGS_{}", target), cflags.clone())
-                .env("CFLAGS", cflags.clone());
+                .env(format!("CFLAGS_{}", target), cflags.clone());
 
             if let Some(ar) = self.ar(target) {
                 let ranlib = format!("{} s", ar.display());
                 cargo
                     .env(format!("AR_{}", target), ar)
-                    .env("AR", ar)
-                    .env(format!("RANLIB_{}", target), ranlib.clone())
-                    .env("RANLIB", ranlib);
+                    .env(format!("RANLIB_{}", target), ranlib);
             }
 
             if let Ok(cxx) = self.cxx(target) {
                 let cxx = ccacheify(&cxx);
                 cargo
                     .env(format!("CXX_{}", target), &cxx)
-                    .env("CXX", &cxx)
-                    .env(format!("CXXFLAGS_{}", target), cflags.clone())
-                    .env("CXXFLAGS", cflags);
+                    .env(format!("CXXFLAGS_{}", target), cflags);
             }
         }