diff options
| author | Petr Hosek <phosek@google.com> | 2018-03-30 19:37:08 -0700 |
|---|---|---|
| committer | Petr Hosek <phosek@google.com> | 2018-03-30 19:37:08 -0700 |
| commit | c6bae16dc2e75456786e0f7af39f0cf9e3186bb5 (patch) | |
| tree | c1704b6008c08011ca9b99a58c4795afadaf3865 /src/bootstrap | |
| parent | 80785a547d29519dbdb5781437ec318fb210b980 (diff) | |
| download | rust-c6bae16dc2e75456786e0f7af39f0cf9e3186bb5.tar.gz rust-c6bae16dc2e75456786e0f7af39f0cf9e3186bb5.zip | |
Only include space in RUSTFLAGS extra flags if not empty
When the RUSTFLAGS_STAGE_{1,2} is not set, including a space means
the string will always be non-empty and RUSTFLAGS will be always be
reset which breaks other ways of setting these such as through config
in CARGO_HOME.
Diffstat (limited to 'src/bootstrap')
| -rw-r--r-- | src/bootstrap/builder.rs | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/bootstrap/builder.rs b/src/bootstrap/builder.rs index eb23236638b..0464840c3e8 100644 --- a/src/bootstrap/builder.rs +++ b/src/bootstrap/builder.rs @@ -555,7 +555,9 @@ impl<'a> Builder<'a> { let mut extra_args = env::var(&format!("RUSTFLAGS_STAGE_{}", stage)).unwrap_or_default(); if stage != 0 { let s = env::var("RUSTFLAGS_STAGE_NOT_0").unwrap_or_default(); - extra_args.push_str(" "); + if !extra_args.is_empty() { + extra_args.push_str(" "); + } extra_args.push_str(&s); } |
