diff options
| author | Mateusz Mikuła <mati865@gmail.com> | 2020-08-11 16:31:32 +0200 |
|---|---|---|
| committer | Mateusz Mikuła <mati865@gmail.com> | 2020-08-11 16:31:32 +0200 |
| commit | 24177319ca8502bd957077671d21abbbb20df4f6 (patch) | |
| tree | 2bb58162fcd87f420d0918ea0798be40033278ac /src/ci/github-actions | |
| parent | d495ef527c6ab41c837ff13ed74f648bacee921f (diff) | |
| download | rust-24177319ca8502bd957077671d21abbbb20df4f6.tar.gz rust-24177319ca8502bd957077671d21abbbb20df4f6.zip | |
Update MinGW comments in ci.yml
Diffstat (limited to 'src/ci/github-actions')
| -rw-r--r-- | src/ci/github-actions/ci.yml | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/src/ci/github-actions/ci.yml b/src/ci/github-actions/ci.yml index 0ff77de003d..165ecc79180 100644 --- a/src/ci/github-actions/ci.yml +++ b/src/ci/github-actions/ci.yml @@ -490,15 +490,17 @@ jobs: # 32/64-bit MinGW builds. # - # We are using MinGW with posix threads since LLVM does not compile with - # the win32 threads version due to missing support for C++'s std::thread. + # We are using MinGW with POSIX threads since LLVM requires + # C++'s std::thread which is disabled in libstdc++ with win32 threads. + # FIXME: Libc++ doesn't have this limitation so we can avoid + # winpthreads if we switch to it. # - # Instead of relying on the MinGW version installed on appveryor we download - # and install one ourselves so we won't be surprised by changes to appveyor's + # Instead of relying on the MinGW version installed on CI we download + # and install one ourselves so we won't be surprised by changes to CI's # build image. # # Finally, note that the downloads below are all in the `rust-lang-ci` S3 - # bucket, but they cleraly didn't originate there! The downloads originally + # bucket, but they clearly didn't originate there! The downloads originally # came from the mingw-w64 SourceForge download site. Unfortunately # SourceForge is notoriously flaky, so we mirror it on our own infrastructure. |