diff options
| author | Noah Lev <camelidcamel@gmail.com> | 2025-01-09 13:24:42 -0800 |
|---|---|---|
| committer | Noah Lev <camelidcamel@gmail.com> | 2025-01-09 13:37:03 -0800 |
| commit | b4297e729f98e2b44b47019157c0de6577996786 (patch) | |
| tree | 88123034fdb1cdec9a8b51d65084d96f7e70010b /src/doc/rustc-dev-guide/.github/workflows | |
| parent | 42c284edec1d3b645bc08666bdbb329c7709b578 (diff) | |
ci: Remove incorrect use of `continue-on-error`
This will cause the CI build to be marked successful even if the build failed. Instead, use `if: '!cancelled()'` to always save the cache (except when the job is cancelled), even if the linkcheck failed. See https://stackoverflow.com/a/58859404 for more.
Diffstat (limited to 'src/doc/rustc-dev-guide/.github/workflows')
| -rw-r--r-- | src/doc/rustc-dev-guide/.github/workflows/ci.yml | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/doc/rustc-dev-guide/.github/workflows/ci.yml b/src/doc/rustc-dev-guide/.github/workflows/ci.yml index 3c45ad16488..006bcce44b3 100644 --- a/src/doc/rustc-dev-guide/.github/workflows/ci.yml +++ b/src/doc/rustc-dev-guide/.github/workflows/ci.yml @@ -59,11 +59,10 @@ jobs: - name: Check build run: ENABLE_LINKCHECK=1 mdbook build - continue-on-error: true - name: Save cached Linkcheck id: cache-linkcheck-save - if: github.event_name == 'schedule' + if: ${{ !cancelled() && github.event_name == 'schedule' }} uses: actions/cache/save@v4 with: path: book/linkcheck/cache.json |