about summary refs log tree commit diff
path: root/src/doc/rustc-dev-guide
diff options
context:
space:
mode:
authorLeón Orell Valerian Liehr <me@fmease.dev>2024-01-14 10:32:35 +0100
committerNilstrieb <48135649+Nilstrieb@users.noreply.github.com>2024-01-14 11:42:53 +0100
commiteba15321f29acae3a047ed752da145b2c83e6d98 (patch)
treeda05bf4cfbe6cea405754930d0223ad3462b20b3 /src/doc/rustc-dev-guide
parent6a50a194626180032e1d56744ce1f29d17765919 (diff)
downloadrust-eba15321f29acae3a047ed752da145b2c83e6d98.tar.gz
rust-eba15321f29acae3a047ed752da145b2c83e6d98.zip
Mention label has-merge-commits
Diffstat (limited to 'src/doc/rustc-dev-guide')
-rw-r--r--src/doc/rustc-dev-guide/src/contributing.md10
1 files changed, 7 insertions, 3 deletions
diff --git a/src/doc/rustc-dev-guide/src/contributing.md b/src/doc/rustc-dev-guide/src/contributing.md
index d6b9fc84dec..925b4d3db15 100644
--- a/src/doc/rustc-dev-guide/src/contributing.md
+++ b/src/doc/rustc-dev-guide/src/contributing.md
@@ -243,7 +243,13 @@ The CI will also run tidy and will fail if tidy fails.
 Rust follows a _no merge-commit policy_, meaning, when you encounter merge
 conflicts you are expected to always rebase instead of merging.  E.g. always use
 rebase when bringing the latest changes from the master branch to your feature
-branch.
+branch. If your PR contains merge commits, it will get marked as `has-merge-commits`.
+Once you have removed the merge commits, e.g., through an interactive rebase, you
+should remove the label again:
+
+    @rustbot label -has-merge-commits
+
+See [this chapter][labeling] for more details.
 
 If you encounter merge conflicts or when a reviewer asks you to perform some
 changes, your PR will get marked as `S-waiting-on-author`. When you resolve
@@ -251,8 +257,6 @@ them, you should use `@rustbot` to mark it as `S-waiting-on-review`:
 
     @rustbot label -S-waiting-on-author +S-waiting-on-review
 
-See [this chapter][labeling] for more details.
-
 GitHub allows [closing issues using keywords][closing-keywords]. This feature
 should be used to keep the issue tracker tidy. However, it is generally preferred
 to put the "closes #123" text in the PR description rather than the issue commit;