diff options
| author | Boxy <rust@boxyuwu.dev> | 2025-05-08 12:26:35 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-05-08 12:26:35 +0100 |
| commit | f31bf4a94e5670570f19efbcd577a3632129cc68 (patch) | |
| tree | 89659e25edb2efc50fbecf31101c6d483e1fc7b9 /src/doc/rustc-dev-guide | |
| parent | f52e1be6954ef3f11907d23a5334b346b7f167dc (diff) | |
| parent | d87763dc4f98e2dcec5c819a678242a0142b80d7 (diff) | |
| download | rust-f31bf4a94e5670570f19efbcd577a3632129cc68.tar.gz rust-f31bf4a94e5670570f19efbcd577a3632129cc68.zip | |
Merge pull request #2323 from smanilov/patch-2
Align advice to discourage issue-number-only names
Diffstat (limited to 'src/doc/rustc-dev-guide')
| -rw-r--r-- | src/doc/rustc-dev-guide/src/tests/best-practices.md | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/doc/rustc-dev-guide/src/tests/best-practices.md b/src/doc/rustc-dev-guide/src/tests/best-practices.md index 2bdc7f3a243..be00207e3fb 100644 --- a/src/doc/rustc-dev-guide/src/tests/best-practices.md +++ b/src/doc/rustc-dev-guide/src/tests/best-practices.md @@ -70,6 +70,11 @@ related tests. > //! > //! Regression test for <https://github.com/rust-lang/rust/issues/123456>. > ``` +> +> One exception to this rule is [crashes tests]: there it is canonical that +> tests are named only after issue numbers because its purpose is to track +> snippets from which issues no longer ICE/crash, and they would either be +> removed or converted into proper ui/other tests in the fix PRs. ## Test organization @@ -194,3 +199,4 @@ See [LLVM FileCheck guide][FileCheck] for details. [compiletest directives]: ./directives.md [`run-make`]: ./compiletest.md#run-make-tests [FileCheck]: https://llvm.org/docs/CommandGuide/FileCheck.html +[crashes tests]: ./compiletest.md#crashes-tests |