diff options
| author | bors <bors@rust-lang.org> | 2015-12-18 18:54:52 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2015-12-18 18:54:52 +0000 |
| commit | ef91cdb140d7dffa4b04f42ab0bc02dc257940e3 (patch) | |
| tree | 440d7f10732b40ed272fbadef1b5c580b1320a2b /src/doc | |
| parent | 29ea4eef9fa6e36f40bc1f31eb1e56bf5941ee72 (diff) | |
| parent | 785cbe02008985f98fee2a013f2d308207ca596f (diff) | |
| download | rust-ef91cdb140d7dffa4b04f42ab0bc02dc257940e3.tar.gz rust-ef91cdb140d7dffa4b04f42ab0bc02dc257940e3.zip | |
Auto merge of #29973 - petrochenkov:privinpub, r=nikomatsakis
Some notes: This patch enforces the rules from [RFC 136](https://github.com/rust-lang/rfcs/blob/master/text/0136-no-privates-in-public.md) and makes "private in public" a module-level concept and not crate-level. Only `pub` annotations are used by the new algorithm, crate-level exported node set produced by `EmbargoVisitor` is not used. The error messages are tweaked accordingly and don't use the word "exported" to avoid confusing people (https://github.com/rust-lang/rust/issues/29668). The old algorithm tried to be extra smart with impls, but it mostly led to unpredictable behavior and bugs like https://github.com/rust-lang/rust/issues/28325. The new algorithm tries to be as simple as possible - an impl is considered public iff its type is public and its trait is public (if presents). A type or trait is considered public if all its components are public, [complications](https://internals.rust-lang.org/t/limits-of-type-inference-smartness/2919) with private types leaking to other crates/modules through trait impls and type inference are deliberately ignored so far. The new algorithm is not recursive and uses the nice new facility `Crate::visit_all_items`! Obsolete pre-1.0 feature `visible_private_types` is removed. This is a [breaking-change]. The two main vectors of breakage are type aliases (https://github.com/rust-lang/rust/issues/28450) and impls (https://github.com/rust-lang/rust/issues/28325). I need some statistics from a crater run (cc @alexcrichton) to decide on the breakage mitigation strategy. UPDATE: All the new errors are reported as warnings controlled by a lint `private_in_public` and lint group `future_incompatible`, but the intent is to make them hard errors eventually. Closes https://github.com/rust-lang/rust/issues/28325 Closes https://github.com/rust-lang/rust/issues/28450 Closes https://github.com/rust-lang/rust/issues/29524 Closes https://github.com/rust-lang/rust/issues/29627 Closes https://github.com/rust-lang/rust/issues/29668 Closes https://github.com/rust-lang/rust/issues/30055 r? @nikomatsakis
Diffstat (limited to 'src/doc')
| -rw-r--r-- | src/doc/reference.md | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/doc/reference.md b/src/doc/reference.md index a20d2571152..a722c0e38f4 100644 --- a/src/doc/reference.md +++ b/src/doc/reference.md @@ -2372,10 +2372,6 @@ The currently implemented features of the reference compiler are: Such items should not be allowed by the compiler to exist, so if you need this there probably is a compiler bug. -* `visible_private_types` - Allows public APIs to expose otherwise private - types, e.g. as the return type of a public function. - This capability may be removed in the future. - * `allow_internal_unstable` - Allows `macro_rules!` macros to be tagged with the `#[allow_internal_unstable]` attribute, designed to allow `std` macros to call |