diff options
| author | Lzu Tao <taolzu@gmail.com> | 2019-10-27 17:31:01 +0000 |
|---|---|---|
| committer | Lzu Tao <taolzu@gmail.com> | 2019-10-27 17:31:01 +0000 |
| commit | 3f980785fb55e31aca9215faa474d751e5a28d69 (patch) | |
| tree | 9c17eb1dc8bf9a5bb9214a2a98a1653fdd1e94ef /src/liballoc | |
| parent | 0f677c65e867d93a47ccbaeaf6e6725cde8c5ff6 (diff) | |
| download | rust-3f980785fb55e31aca9215faa474d751e5a28d69.tar.gz rust-3f980785fb55e31aca9215faa474d751e5a28d69.zip | |
doc: explain why it is unsafe to construct Vec<u8> from Vec<u16>
Co-authored-by: Steve Klabnik <steve@steveklabnik.com>
Diffstat (limited to 'src/liballoc')
| -rw-r--r-- | src/liballoc/vec.rs | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/liballoc/vec.rs b/src/liballoc/vec.rs index 641f9eafa8d..5e733fa43d7 100644 --- a/src/liballoc/vec.rs +++ b/src/liballoc/vec.rs @@ -411,7 +411,11 @@ impl<T> Vec<T> { /// /// Violating these may cause problems like corrupting the allocator's /// internal data structures. For example it is **not** safe - /// to build a `Vec<u8>` from a pointer to a C `char` array and a `size_t`. + /// to build a `Vec<u8>` from a pointer to a C `char` array with length `size_t`. + /// It's also not safe to build one from a `Vec<u16>` and its length, because + /// the allocator cares about the alignment, and these two types have different + /// alignments. The buffer was allocated with alignment 2 (for `u16`), but after + /// turning it into a `Vec<u8>` it'll be deallocated with alignment 1. /// /// The ownership of `ptr` is effectively transferred to the /// `Vec<T>` which may then deallocate, reallocate or change the |
