about summary refs log tree commit diff
path: root/src/liballoc
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2018-05-12 05:42:10 +0000
committerbors <bors@rust-lang.org>2018-05-12 05:42:10 +0000
commit5f98fe714e8e5638fd38cb238c50508c2600002f (patch)
tree77ca0e53c7f2bd8018c97f79366c961532c8b8e7 /src/liballoc
parentc705877b1df780acfb2dcba4ebca6f30102dd8a2 (diff)
parent7006018745566fae2f09f6fc201cf4f6de6a4414 (diff)
downloadrust-5f98fe714e8e5638fd38cb238c50508c2600002f.tar.gz
rust-5f98fe714e8e5638fd38cb238c50508c2600002f.zip
Auto merge of #50476 - zackmdavis:tame_unreachable_pub_suggestion, r=Manishearth
don't make crazy suggestion for unreachable braced pub-use

The Higher Intermediate Representation doesn't have spans for visibility
keywords, so we were assuming that the first whitespace-delimited token
in the item span was the `pub` to be weakened. This doesn't work for
brace-grouped `use`s, which get lowered as if they were several
individual `use` statements, but with spans that only cover the braced
path-segments. Constructing a correct suggestion here presents some
challenges—until someone works those out, we can at least protect the
dignity of our compiler by not offering any suggestion at all for `use` items.

This resolves #50455 (but again, it would be desirable in the future to
make a correct suggestion instead of copping out like this).

r? @Manishearth
Diffstat (limited to 'src/liballoc')
0 files changed, 0 insertions, 0 deletions