diff options
| author | Alex Crichton <alex@alexcrichton.com> | 2014-05-10 14:05:06 -0700 |
|---|---|---|
| committer | Alex Crichton <alex@alexcrichton.com> | 2014-05-15 23:22:06 -0700 |
| commit | 1de4b65d2a88e88201026485f9622916c5717555 (patch) | |
| tree | 1aa5e8506b8367075cfa4f1546c27df2a943dff9 /src/libcollections | |
| parent | 8767093eb98358a1d62a934a58e1c89c72223cd6 (diff) | |
| download | rust-1de4b65d2a88e88201026485f9622916c5717555.tar.gz rust-1de4b65d2a88e88201026485f9622916c5717555.zip | |
Updates with core::fmt changes
1. Wherever the `buf` field of a `Formatter` was used, the `Formatter` is used instead. 2. The usage of `write_fmt` is minimized as much as possible, the `write!` macro is preferred wherever possible. 3. Usage of `fmt::write` is minimized, favoring the `write!` macro instead.
Diffstat (limited to 'src/libcollections')
| -rw-r--r-- | src/libcollections/btree.rs | 14 | ||||
| -rw-r--r-- | src/libcollections/hashmap.rs | 16 | ||||
| -rw-r--r-- | src/libcollections/lru_cache.rs | 12 |
3 files changed, 21 insertions, 21 deletions
diff --git a/src/libcollections/btree.rs b/src/libcollections/btree.rs index 245040d791c..ba83ad8d37c 100644 --- a/src/libcollections/btree.rs +++ b/src/libcollections/btree.rs @@ -425,8 +425,8 @@ impl<K: fmt::Show + TotalOrd, V: fmt::Show> fmt::Show for Leaf<K, V> { ///Returns a string representation of a Leaf. fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { for (i, s) in self.elts.iter().enumerate() { - if i != 0 { try!(write!(f.buf, " // ")) } - try!(write!(f.buf, "{}", *s)) + if i != 0 { try!(write!(f, " // ")) } + try!(write!(f, "{}", *s)) } Ok(()) } @@ -654,10 +654,10 @@ impl<K: fmt::Show + TotalOrd, V: fmt::Show> fmt::Show for Branch<K, V> { ///Returns a string representation of a Branch. fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { for (i, s) in self.elts.iter().enumerate() { - if i != 0 { try!(write!(f.buf, " // ")) } - try!(write!(f.buf, "{}", *s)) + if i != 0 { try!(write!(f, " // ")) } + try!(write!(f, "{}", *s)) } - write!(f.buf, " // rightmost child: ({}) ", *self.rightmost_child) + write!(f, " // rightmost child: ({}) ", *self.rightmost_child) } } @@ -715,7 +715,7 @@ impl<K: TotalOrd, V: TotalEq> TotalOrd for LeafElt<K, V> { impl<K: fmt::Show + TotalOrd, V: fmt::Show> fmt::Show for LeafElt<K, V> { ///Returns a string representation of a LeafElt. fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { - write!(f.buf, "Key: {}, value: {};", self.key, self.value) + write!(f, "Key: {}, value: {};", self.key, self.value) } } @@ -765,7 +765,7 @@ impl<K: fmt::Show + TotalOrd, V: fmt::Show> fmt::Show for BranchElt<K, V> { /// Returns string containing key, value, and child (which should recur to a /// leaf) Consider changing in future to be more readable. fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { - write!(f.buf, "Key: {}, value: {}, (child: {})", + write!(f, "Key: {}, value: {}, (child: {})", self.key, self.value, *self.left) } } diff --git a/src/libcollections/hashmap.rs b/src/libcollections/hashmap.rs index 4b9c8ccadd2..4259f458e00 100644 --- a/src/libcollections/hashmap.rs +++ b/src/libcollections/hashmap.rs @@ -1418,14 +1418,14 @@ impl<K: TotalEq + Hash<S>, V: Eq, S, H: Hasher<S>> Eq for HashMap<K, V, H> { impl<K: TotalEq + Hash<S> + Show, V: Show, S, H: Hasher<S>> Show for HashMap<K, V, H> { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { - try!(write!(f.buf, r"\{")); + try!(write!(f, r"\{")); for (i, (k, v)) in self.iter().enumerate() { - if i != 0 { try!(write!(f.buf, ", ")); } - try!(write!(f.buf, "{}: {}", *k, *v)); + if i != 0 { try!(write!(f, ", ")); } + try!(write!(f, "{}: {}", *k, *v)); } - write!(f.buf, r"\}") + write!(f, r"\}") } } @@ -1605,14 +1605,14 @@ impl<T: TotalEq + Hash<S>, S, H: Hasher<S>> HashSet<T, H> { impl<T: TotalEq + Hash<S> + fmt::Show, S, H: Hasher<S>> fmt::Show for HashSet<T, H> { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { - try!(write!(f.buf, r"\{")); + try!(write!(f, r"\{")); for (i, x) in self.iter().enumerate() { - if i != 0 { try!(write!(f.buf, ", ")); } - try!(write!(f.buf, "{}", *x)); + if i != 0 { try!(write!(f, ", ")); } + try!(write!(f, "{}", *x)); } - write!(f.buf, r"\}") + write!(f, r"\}") } } diff --git a/src/libcollections/lru_cache.rs b/src/libcollections/lru_cache.rs index 72eefe4f44d..8fdc0e095bf 100644 --- a/src/libcollections/lru_cache.rs +++ b/src/libcollections/lru_cache.rs @@ -205,20 +205,20 @@ impl<A: fmt::Show + Hash + TotalEq, B: fmt::Show> fmt::Show for LruCache<A, B> { /// Return a string that lists the key-value pairs from most-recently /// used to least-recently used. fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { - try!(write!(f.buf, r"\{")); + try!(write!(f, r"\{")); let mut cur = self.head; for i in range(0, self.len()) { - if i > 0 { try!(write!(f.buf, ", ")) } + if i > 0 { try!(write!(f, ", ")) } unsafe { cur = (*cur).next; - try!(write!(f.buf, "{}", (*cur).key)); + try!(write!(f, "{}", (*cur).key)); } - try!(write!(f.buf, ": ")); + try!(write!(f, ": ")); unsafe { - try!(write!(f.buf, "{}", (*cur).value)); + try!(write!(f, "{}", (*cur).value)); } } - write!(f.buf, r"\}") + write!(f, r"\}") } } |
