about summary refs log tree commit diff
path: root/src/libcore/task
diff options
context:
space:
mode:
authorBrian Anderson <banderson@mozilla.com>2013-04-08 16:07:54 -0700
committerBrian Anderson <banderson@mozilla.com>2013-04-08 16:16:32 -0700
commit2e907a3ac2fcaa799f570e07c35f54efae39829b (patch)
tree50bb377deafe87db4ba3b42a30bada5c3979f802 /src/libcore/task
parent5a0f62850107edab30e51c1e31c8b0c7e443f972 (diff)
downloadrust-2e907a3ac2fcaa799f570e07c35f54efae39829b.tar.gz
rust-2e907a3ac2fcaa799f570e07c35f54efae39829b.zip
core: Remove all but one drop block in favor of `finally`
Diffstat (limited to 'src/libcore/task')
-rw-r--r--src/libcore/task/mod.rs69
1 files changed, 17 insertions, 52 deletions
diff --git a/src/libcore/task/mod.rs b/src/libcore/task/mod.rs
index ee454312e04..502efcf9dc6 100644
--- a/src/libcore/task/mod.rs
+++ b/src/libcore/task/mod.rs
@@ -42,6 +42,7 @@ use result;
 use task::rt::{task_id, sched_id, rust_task};
 use util;
 use util::replace;
+use unstable::finally::Finally;
 
 #[cfg(test)] use comm::SharedChan;
 
@@ -565,51 +566,27 @@ pub fn get_scheduler() -> Scheduler {
  * ~~~
  */
 pub unsafe fn unkillable<U>(f: &fn() -> U) -> U {
-    struct AllowFailure {
-        t: *rust_task,
-        drop {
-            unsafe {
-                rt::rust_task_allow_kill(self.t);
-            }
-        }
-    }
-
-    fn AllowFailure(t: *rust_task) -> AllowFailure{
-        AllowFailure {
-            t: t
-        }
-    }
-
     unsafe {
         let t = rt::rust_get_task();
-        let _allow_failure = AllowFailure(t);
         rt::rust_task_inhibit_kill(t);
-        f()
+        do (|| {
+            f()
+        }).finally {
+            rt::rust_task_allow_kill(t);
+        }
     }
 }
 
 /// The inverse of unkillable. Only ever to be used nested in unkillable().
 pub unsafe fn rekillable<U>(f: &fn() -> U) -> U {
-    struct DisallowFailure {
-        t: *rust_task,
-        drop {
-            unsafe {
-                rt::rust_task_inhibit_kill(self.t);
-            }
-        }
-    }
-
-    fn DisallowFailure(t: *rust_task) -> DisallowFailure {
-        DisallowFailure {
-            t: t
-        }
-    }
-
     unsafe {
         let t = rt::rust_get_task();
-        let _allow_failure = DisallowFailure(t);
         rt::rust_task_allow_kill(t);
-        f()
+        do (|| {
+            f()
+        }).finally {
+            rt::rust_task_inhibit_kill(t);
+        }
     }
 }
 
@@ -618,28 +595,16 @@ pub unsafe fn rekillable<U>(f: &fn() -> U) -> U {
  * For use with exclusive ARCs, which use pthread mutexes directly.
  */
 pub unsafe fn atomically<U>(f: &fn() -> U) -> U {
-    struct DeferInterrupts {
-        t: *rust_task,
-        drop {
-            unsafe {
-                rt::rust_task_allow_yield(self.t);
-                rt::rust_task_allow_kill(self.t);
-            }
-        }
-    }
-
-    fn DeferInterrupts(t: *rust_task) -> DeferInterrupts {
-        DeferInterrupts {
-            t: t
-        }
-    }
-
     unsafe {
         let t = rt::rust_get_task();
-        let _interrupts = DeferInterrupts(t);
         rt::rust_task_inhibit_kill(t);
         rt::rust_task_inhibit_yield(t);
-        f()
+        do (|| {
+            f()
+        }).finally {
+            rt::rust_task_allow_yield(t);
+            rt::rust_task_allow_kill(t);
+        }
     }
 }