diff options
| author | Andre Bogus <bogusandre@gmail.com> | 2019-12-11 20:49:46 +0100 |
|---|---|---|
| committer | Andre Bogus <bogusandre@gmail.com> | 2019-12-11 20:49:46 +0100 |
| commit | 7f87dd1bc008d49cc27bee8d5a866e3c2de463b3 (patch) | |
| tree | 1951551190e515820d1b6a87da95c0f076fd54f4 /src/libcore | |
| parent | 90b957a17c1abba979aa41234ce0993a61030e67 (diff) | |
| download | rust-7f87dd1bc008d49cc27bee8d5a866e3c2de463b3.tar.gz rust-7f87dd1bc008d49cc27bee8d5a866e3c2de463b3.zip | |
Some small readability improvements
Diffstat (limited to 'src/libcore')
| -rw-r--r-- | src/libcore/char/methods.rs | 15 | ||||
| -rw-r--r-- | src/libcore/str/pattern.rs | 7 |
2 files changed, 6 insertions, 16 deletions
diff --git a/src/libcore/char/methods.rs b/src/libcore/char/methods.rs index 1ec614edbe2..5c63eebf595 100644 --- a/src/libcore/char/methods.rs +++ b/src/libcore/char/methods.rs @@ -553,8 +553,7 @@ impl char { pub fn is_alphabetic(self) -> bool { match self { 'a'..='z' | 'A'..='Z' => true, - c if c > '\x7f' => derived_property::Alphabetic(c), - _ => false, + c => c > '\x7f' && derived_property::Alphabetic(c), } } @@ -585,8 +584,7 @@ impl char { pub fn is_lowercase(self) -> bool { match self { 'a'..='z' => true, - c if c > '\x7f' => derived_property::Lowercase(c), - _ => false, + c => c > '\x7f' && derived_property::Lowercase(c), } } @@ -617,8 +615,7 @@ impl char { pub fn is_uppercase(self) -> bool { match self { 'A'..='Z' => true, - c if c > '\x7f' => derived_property::Uppercase(c), - _ => false, + c => c > '\x7f' && derived_property::Uppercase(c), } } @@ -646,8 +643,7 @@ impl char { pub fn is_whitespace(self) -> bool { match self { ' ' | '\x09'..='\x0d' => true, - c if c > '\x7f' => property::White_Space(c), - _ => false, + c => c > '\x7f' && property::White_Space(c), } } @@ -744,8 +740,7 @@ impl char { pub fn is_numeric(self) -> bool { match self { '0'..='9' => true, - c if c > '\x7f' => general_category::N(c), - _ => false, + c => c > '\x7f' && general_category::N(c), } } diff --git a/src/libcore/str/pattern.rs b/src/libcore/str/pattern.rs index a494274118a..1037da14b5f 100644 --- a/src/libcore/str/pattern.rs +++ b/src/libcore/str/pattern.rs @@ -296,12 +296,7 @@ unsafe impl<'a> Searcher<'a> for CharSearcher<'a> { fn next_match(&mut self) -> Option<(usize, usize)> { loop { // get the haystack after the last character found - let bytes = if let Some(slice) = self.haystack.as_bytes() - .get(self.finger..self.finger_back) { - slice - } else { - return None; - }; + let bytes = self.haystack.as_bytes().get(self.finger..self.finger_back)?; // the last byte of the utf8 encoded needle let last_byte = unsafe { *self.utf8_encoded.get_unchecked(self.utf8_size - 1) }; if let Some(index) = memchr::memchr(last_byte, bytes) { |
