diff options
| author | Alex Crichton <alex@alexcrichton.com> | 2014-01-06 14:17:23 -0800 |
|---|---|---|
| committer | Alex Crichton <alex@alexcrichton.com> | 2014-01-06 16:32:51 -0800 |
| commit | 03e91573c73dbaa6afc905c6b14df4bb327589c9 (patch) | |
| tree | 5518b4e70db6ece31171438d7eb74ca4393d59bc /src/libnative | |
| parent | 3afa0b97c4ce81b3bbfd1e0dd4a6609742957678 (diff) | |
| download | rust-03e91573c73dbaa6afc905c6b14df4bb327589c9.tar.gz rust-03e91573c73dbaa6afc905c6b14df4bb327589c9.zip | |
Don't read forever on a file descriptor
Similarly to the recent commit to do this for networking, there's no reason that a read on a file descriptor should continue reading until the entire buffer is full. This makes sense when dealing with literal files, but when dealing with things like stdin this doesn't make sense.
Diffstat (limited to 'src/libnative')
| -rw-r--r-- | src/libnative/io/file.rs | 8 | ||||
| -rw-r--r-- | src/libnative/lib.rs | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/libnative/io/file.rs b/src/libnative/io/file.rs index 0021dfcb881..dac1ca98cf9 100644 --- a/src/libnative/io/file.rs +++ b/src/libnative/io/file.rs @@ -79,10 +79,10 @@ impl FileDesc { pub fn inner_read(&mut self, buf: &mut [u8]) -> Result<uint, IoError> { #[cfg(windows)] type rlen = libc::c_uint; #[cfg(not(windows))] type rlen = libc::size_t; - let ret = keep_going(buf, |buf, len| { - unsafe { - libc::read(self.fd, buf as *mut libc::c_void, len as rlen) as i64 - } + let ret = retry(|| unsafe { + libc::read(self.fd, + buf.as_ptr() as *mut libc::c_void, + buf.len() as rlen) as libc::c_int }); if ret == 0 { Err(io::standard_error(io::EndOfFile)) diff --git a/src/libnative/lib.rs b/src/libnative/lib.rs index 9c30e94194d..31395216f2b 100644 --- a/src/libnative/lib.rs +++ b/src/libnative/lib.rs @@ -34,7 +34,7 @@ pub mod io; pub mod task; // XXX: this should not exist here -#[cfg(stage0)] +#[cfg(stage0, nativestart)] #[lang = "start"] pub fn lang_start(main: *u8, argc: int, argv: **u8) -> int { use std::cast; |
