diff options
| author | bors <bors@rust-lang.org> | 2014-02-28 13:26:30 -0800 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2014-02-28 13:26:30 -0800 |
| commit | 5b4a141b6adceeb82f5a2c97cdf55224fa56826e (patch) | |
| tree | bc3e975c830c50d72ae5ac89c339a9ef43d70a2c /src/libnative | |
| parent | 84ebf74ee2f163461cf021b3d415171e8b5ef8be (diff) | |
| parent | ddc1c21264898f6a5d12cf03bba30f1f08b73665 (diff) | |
| download | rust-5b4a141b6adceeb82f5a2c97cdf55224fa56826e.tar.gz rust-5b4a141b6adceeb82f5a2c97cdf55224fa56826e.zip | |
auto merge of #12616 : alexcrichton/rust/size, r=huonw
I've been playing around with code size when linking to libstd recently, and these were some findings I found that really helped code size. I started out by eliminating all I/O implementations from libnative and instead just return an unimplemented error.
In doing so, a `fn main() {}` executable was ~378K before this patch, and about 170K after the patch. These size wins are all pretty minor, but they all seemed pretty reasonable to me. With native I/O not stubbed out, this takes the size of an LTO executable from 675K to 400K.
Diffstat (limited to 'src/libnative')
| -rw-r--r-- | src/libnative/io/process.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/libnative/io/process.rs b/src/libnative/io/process.rs index 0b833f47395..6ac1f2b3692 100644 --- a/src/libnative/io/process.rs +++ b/src/libnative/io/process.rs @@ -470,7 +470,7 @@ fn spawn_process_os(config: p::ProcessConfig, Err(e) => { assert!(e.kind == io::BrokenPipe || e.kind == io::EndOfFile, - "unexpected error: {:?}", e); + "unexpected error: {}", e); Ok(SpawnProcessResult { pid: pid, handle: ptr::null() @@ -744,7 +744,7 @@ fn waitpid(pid: pid_t) -> p::ProcessExit { let mut status = 0 as c_int; match retry(|| unsafe { wait::waitpid(pid, &mut status, 0) }) { - -1 => fail!("unknown waitpid error: {:?}", super::last_error()), + -1 => fail!("unknown waitpid error: {}", super::last_error()), _ => { if imp::WIFEXITED(status) { p::ExitStatus(imp::WEXITSTATUS(status) as int) |
