about summary refs log tree commit diff
path: root/src/librustc_codegen_llvm/attributes.rs
diff options
context:
space:
mode:
authorFelix S Klock II <pnkfelix@pnkfx.org>2019-10-03 10:46:01 +0200
committerGitHub <noreply@github.com>2019-10-03 10:46:01 +0200
commite7e6dec06a050c5bc4e7a93e6700fad28570779a (patch)
treef09037ec3fc26922864d09328b2514049c7527f4 /src/librustc_codegen_llvm/attributes.rs
parent3adcc3ed222bdc6fc669281c42ef933aa3f6116b (diff)
downloadrust-e7e6dec06a050c5bc4e7a93e6700fad28570779a.tar.gz
rust-e7e6dec06a050c5bc4e7a93e6700fad28570779a.zip
Apply suggestions from code review
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Co-Authored-By: Ralf Jung <post@ralfj.de>
Diffstat (limited to 'src/librustc_codegen_llvm/attributes.rs')
-rw-r--r--src/librustc_codegen_llvm/attributes.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/librustc_codegen_llvm/attributes.rs b/src/librustc_codegen_llvm/attributes.rs
index 4189904a801..73d43289d19 100644
--- a/src/librustc_codegen_llvm/attributes.rs
+++ b/src/librustc_codegen_llvm/attributes.rs
@@ -281,7 +281,7 @@ pub fn from_fn_attrs(
         //
         // However, in the long term we should either:
         // - fold this into final else (i.e. stop inspecting `id`)
-        // - or better still: whole-heartedly adopt Rust PR #63909.
+        // - adopt Rust PR #63909.
         //
         // see also Rust RFC 2753.
 
@@ -294,7 +294,7 @@ pub fn from_fn_attrs(
         } else {
             // Anything else is either:
             //
-            //  1. A foreign item (like `extern "C" { fn foo(); }`), or
+            //  1. A foreign item using a non-Rust ABI (like `extern "C" { fn foo(); }`), or
             //
             //  2. A Rust item using a non-Rust ABI (like `extern "C" fn foo() { ... }`).
             //