diff options
| author | bors <bors@rust-lang.org> | 2019-08-07 09:33:34 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2019-08-07 09:33:34 +0000 |
| commit | d4abb08be6c3a06a14e285396f5e3ef367584f77 (patch) | |
| tree | ad10c5c02dbcc73bd78f0c16dfcb60c3118acaec /src/librustc_codegen_llvm/debuginfo | |
| parent | 5421d94960018235654c7fb39aa1c502a3564621 (diff) | |
| parent | 0410e320e28d0d2dfcc99d4d5ffcf7a6e5559b89 (diff) | |
| download | rust-d4abb08be6c3a06a14e285396f5e3ef367584f77.tar.gz rust-d4abb08be6c3a06a14e285396f5e3ef367584f77.zip | |
Auto merge of #61919 - alexreg:fix-atb-1, r=nikomatsakis
Fix for "ambiguous associated type" issue with ATBs Fixes #61752. r? @nikomatsakis CC @Centril
Diffstat (limited to 'src/librustc_codegen_llvm/debuginfo')
| -rw-r--r-- | src/librustc_codegen_llvm/debuginfo/metadata.rs | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/librustc_codegen_llvm/debuginfo/metadata.rs b/src/librustc_codegen_llvm/debuginfo/metadata.rs index 3b7aee84862..51e789b1788 100644 --- a/src/librustc_codegen_llvm/debuginfo/metadata.rs +++ b/src/librustc_codegen_llvm/debuginfo/metadata.rs @@ -450,11 +450,11 @@ fn subroutine_type_metadata( false); } -// FIXME(1563) This is all a bit of a hack because 'trait pointer' is an ill- -// defined concept. For the case of an actual trait pointer (i.e., Box<Trait>, -// &Trait), trait_object_type should be the whole thing (e.g, Box<Trait>) and -// trait_type should be the actual trait (e.g., Trait). Where the trait is part -// of a DST struct, there is no trait_object_type and the results of this +// FIXME(1563): This is all a bit of a hack because 'trait pointer' is an ill- +// defined concept. For the case of an actual trait pointer (i.e., `Box<Trait>`, +// `&Trait`), `trait_object_type` should be the whole thing (e.g, `Box<Trait>`) and +// `trait_type` should be the actual trait (e.g., `Trait`). Where the trait is part +// of a DST struct, there is no `trait_object_type` and the results of this // function will be a little bit weird. fn trait_pointer_metadata( cx: &CodegenCx<'ll, 'tcx>, @@ -464,13 +464,13 @@ fn trait_pointer_metadata( ) -> &'ll DIType { // The implementation provided here is a stub. It makes sure that the trait // type is assigned the correct name, size, namespace, and source location. - // But it does not describe the trait's methods. + // However, it does not describe the trait's methods. let containing_scope = match trait_type.sty { ty::Dynamic(ref data, ..) => data.principal_def_id().map(|did| get_namespace_for_item(cx, did)), _ => { - bug!("debuginfo: Unexpected trait-object type in \ + bug!("debuginfo: unexpected trait-object type in \ trait_pointer_metadata(): {:?}", trait_type); } |
