about summary refs log tree commit diff
path: root/src/librustc_codegen_llvm
diff options
context:
space:
mode:
authorJonas Schievink <jonasschievink@gmail.com>2020-02-09 18:23:31 +0100
committerGitHub <noreply@github.com>2020-02-09 18:23:31 +0100
commit0e23d3681e1149d7efc6fc80876288a0c4bbbd05 (patch)
tree0d0a341ab95eb6e9e66170d7c184b0cfb7982aac /src/librustc_codegen_llvm
parent3516df3ecbc97a449221e7a02cf750bf8726b5c1 (diff)
parentb82f6c575e53f06c3645f66a9d480b4f025ee39e (diff)
downloadrust-0e23d3681e1149d7efc6fc80876288a0c4bbbd05.tar.gz
rust-0e23d3681e1149d7efc6fc80876288a0c4bbbd05.zip
Rollup merge of #68881 - eddyb:always-preserve-dbg-vars, r=nagisa
rustc_codegen_llvm: always set AlwaysPreserve on all debuginfo variables

Making this depend on the optimization level appears to have been a copy-paste mistake (other LLVM functions called in this module also take a `bool` argument, but there it means something unrelated).
Also see https://github.com/rust-lang/rust/pull/8855#discussion_r374392128.

I don't believe we have any reason to let LLVM omit user variables from DWARF, and we were already setting this to `true` when LLVM *could* optimize them away, so this PR should have no effect anyway.

r? @michaelwoerister or @nagisa cc @hanna-kruppe @nikomatsakis
Diffstat (limited to 'src/librustc_codegen_llvm')
-rw-r--r--src/librustc_codegen_llvm/debuginfo/mod.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/librustc_codegen_llvm/debuginfo/mod.rs b/src/librustc_codegen_llvm/debuginfo/mod.rs
index c1a7bb50878..22effb102fd 100644
--- a/src/librustc_codegen_llvm/debuginfo/mod.rs
+++ b/src/librustc_codegen_llvm/debuginfo/mod.rs
@@ -559,7 +559,7 @@ impl DebugInfoMethods<'tcx> for CodegenCx<'ll, 'tcx> {
                 file_metadata,
                 loc.line as c_uint,
                 type_metadata,
-                self.sess().opts.optimize != config::OptLevel::No,
+                true,
                 DIFlags::FlagZero,
                 argument_index,
                 align.bytes() as u32,