diff options
| author | Vadim Petrochenkov <vadim.petrochenkov@gmail.com> | 2020-03-09 12:42:33 +0300 |
|---|---|---|
| committer | Vadim Petrochenkov <vadim.petrochenkov@gmail.com> | 2020-03-09 13:07:21 +0300 |
| commit | 7a30bb1676690596f73659d18959877d993510ae (patch) | |
| tree | 5532f195ac6561f5a47a7ae44c18d235f73e06b8 /src/librustc_parse/parser | |
| parent | 9be233cbfe134f032ed2d50f7cc66e901bbe3f6f (diff) | |
| download | rust-7a30bb1676690596f73659d18959877d993510ae.tar.gz rust-7a30bb1676690596f73659d18959877d993510ae.zip | |
Address review comments
Diffstat (limited to 'src/librustc_parse/parser')
| -rw-r--r-- | src/librustc_parse/parser/expr.rs | 13 | ||||
| -rw-r--r-- | src/librustc_parse/parser/item.rs | 2 |
2 files changed, 7 insertions, 8 deletions
diff --git a/src/librustc_parse/parser/expr.rs b/src/librustc_parse/parser/expr.rs index d28b9cd9682..bfca9f07f05 100644 --- a/src/librustc_parse/parser/expr.rs +++ b/src/librustc_parse/parser/expr.rs @@ -97,9 +97,8 @@ impl<'a> Parser<'a> { match self.parse_expr() { Ok(expr) => Ok(expr), Err(mut err) => match self.token.ident() { - Some((ident, false)) - if ident.name == kw::Underscore - && self.look_ahead(1, |t| t == &token::Comma) => + Some((Ident { name: kw::Underscore, .. }, false)) + if self.look_ahead(1, |t| t == &token::Comma) => { // Special-case handling of `foo(_, _, _)` err.emit(); @@ -333,13 +332,13 @@ impl<'a> Parser<'a> { fn check_assoc_op(&self) -> Option<Spanned<AssocOp>> { let (op, span) = match (AssocOp::from_token(&self.token), self.token.ident()) { (Some(op), _) => (op, self.token.span), - (None, Some((ident, false))) if ident.name == sym::and => { + (None, Some((Ident { name: sym::and, span }, false))) => { self.error_bad_logical_op("and", "&&", "conjunction"); - (AssocOp::LAnd, ident.span) + (AssocOp::LAnd, span) } - (None, Some((ident, false))) if ident.name == sym::or => { + (None, Some((Ident { name: sym::or, span }, false))) => { self.error_bad_logical_op("or", "||", "disjunction"); - (AssocOp::LOr, ident.span) + (AssocOp::LOr, span) } _ => return None, }; diff --git a/src/librustc_parse/parser/item.rs b/src/librustc_parse/parser/item.rs index bf612bfc0e4..126686c8def 100644 --- a/src/librustc_parse/parser/item.rs +++ b/src/librustc_parse/parser/item.rs @@ -751,7 +751,7 @@ impl<'a> Parser<'a> { fn parse_ident_or_underscore(&mut self) -> PResult<'a, ast::Ident> { match self.token.ident() { - Some((ident, false)) if ident.name == kw::Underscore => { + Some((ident @ Ident { name: kw::Underscore, .. }, false)) => { self.bump(); Ok(ident) } |
