diff options
| author | Michael Howell <michael@notriddle.com> | 2024-04-09 17:26:59 -0700 |
|---|---|---|
| committer | Michael Howell <michael@notriddle.com> | 2024-04-09 19:35:23 -0700 |
| commit | 87faa212fbc9f80daec903aa1bab1f997897bec4 (patch) | |
| tree | bd585ea3c3d9e83d52b3fb22d12c9a18b745dd51 /src/librustdoc/html | |
| parent | 13235dce5d0af794e48150e99329fc90faaa1f01 (diff) | |
| download | rust-87faa212fbc9f80daec903aa1bab1f997897bec4.tar.gz rust-87faa212fbc9f80daec903aa1bab1f997897bec4.zip | |
rustdoc: remove unused 16x16 favicon
According to <https://caniuse.com/?search=svg%20favicon>, SVG favicons are supported in everything but Safari. When I actually try it in Safari, it's downloading all three favicons, and nothing looks different when I disable the 16x16 one. <https://dev.to/masakudamatsu/favicon-nightmare-how-to-maintain-sanity-3al7>, which is linked from caniuse above, recommends an ico. However, the reason they recommend it is the apps that only support /favicon.ico exactly, and rustdoc can't assume it will be installed to the site root, so it's unfortunately up to the webmaster to make sure it's set up.
Diffstat (limited to 'src/librustdoc/html')
| -rw-r--r-- | src/librustdoc/html/static/images/favicon-16x16.png | bin | 715 -> 0 bytes | |||
| -rw-r--r-- | src/librustdoc/html/static_files.rs | 1 | ||||
| -rw-r--r-- | src/librustdoc/html/templates/page.html | 2 |
3 files changed, 0 insertions, 3 deletions
diff --git a/src/librustdoc/html/static/images/favicon-16x16.png b/src/librustdoc/html/static/images/favicon-16x16.png deleted file mode 100644 index ea4b45cae16..00000000000 --- a/src/librustdoc/html/static/images/favicon-16x16.png +++ /dev/null Binary files differdiff --git a/src/librustdoc/html/static_files.rs b/src/librustdoc/html/static_files.rs index ca9a78f51b3..d8874c2fda0 100644 --- a/src/librustdoc/html/static_files.rs +++ b/src/librustdoc/html/static_files.rs @@ -106,7 +106,6 @@ static_files! { license_mit => "static/LICENSE-MIT.txt", rust_logo_svg => "static/images/rust-logo.svg", rust_favicon_svg => "static/images/favicon.svg", - rust_favicon_png_16 => "static/images/favicon-16x16.png", rust_favicon_png_32 => "static/images/favicon-32x32.png", fira_sans_regular => "static/fonts/FiraSans-Regular.woff2", fira_sans_medium => "static/fonts/FiraSans-Medium.woff2", diff --git a/src/librustdoc/html/templates/page.html b/src/librustdoc/html/templates/page.html index 0e7f7ab2b10..0941f758de5 100644 --- a/src/librustdoc/html/templates/page.html +++ b/src/librustdoc/html/templates/page.html @@ -59,8 +59,6 @@ <link rel="icon" href="{{layout.favicon}}"> {# #} {% else %} <link rel="alternate icon" type="image/png" {#+ #} - href="{{static_root_path|safe}}{{files.rust_favicon_png_16}}"> {# #} - <link rel="alternate icon" type="image/png" {#+ #} href="{{static_root_path|safe}}{{files.rust_favicon_png_32}}"> {# #} <link rel="icon" type="image/svg+xml" {#+ #} href="{{static_root_path|safe}}{{files.rust_favicon_svg}}"> {# #} |
