about summary refs log tree commit diff
path: root/src/libstd/array.rs
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2015-06-27 05:06:22 +0000
committerbors <bors@rust-lang.org>2015-06-27 05:06:22 +0000
commitd3c03d098747be06286f2aebc1e76f8c08352fdf (patch)
tree2059612a95a7a6032f8321b7fab55b1c5b6766c6 /src/libstd/array.rs
parent773052a608736b873906f9bf1c3fd222d0b54764 (diff)
parent759a7f1f66490191a6f809c9709151d6d27cea87 (diff)
downloadrust-d3c03d098747be06286f2aebc1e76f8c08352fdf.tar.gz
rust-d3c03d098747be06286f2aebc1e76f8c08352fdf.zip
Auto merge of #26569 - alexcrichton:msvc-llvm-update, r=brson
Now that LLVM has been updated, the only remaining roadblock to implementing
unwinding for MSVC is to fill out the runtime support in `std::rt::unwind::seh`.
This commit does precisely that, fixing up some other bits and pieces along the
way:

* The `seh` unwinding module now uses `RaiseException` to initiate a panic.
* The `rust_try.ll` file was rewritten for MSVC (as it's quite different) and is
  located at `rust_try_msvc_64.ll`, only included on MSVC builds for now.
* The personality function for all landing pads generated by LLVM is hard-wired
  to `__C_specific_handler` instead of the standard `rust_eh_personality` lang
  item. This is required to get LLVM to emit SEH unwinding information instead
  of DWARF unwinding information. This also means that on MSVC the
  `rust_eh_personality` function is entirely unused (but is defined as it's a
  lang item).

More details about how panicking works on SEH can be found in the
`rust_try_msvc_64.ll` or `seh.rs` files, but I'm always open to adding more
comments!

A key aspect of this PR is missing, however, which is that **unwinding is still
turned off by default for MSVC**. There is a [bug in llvm][llvm-bug] which
causes optimizations to inline enough landing pads that LLVM chokes. If the
compiler is optimized at `-O1` (where inlining isn't enabled) then it can
bootstrap with unwinding enabled, but when optimized at `-O2` (inlining is
enabled) then it hits a fatal LLVM error.

[llvm-bug]: https://llvm.org/bugs/show_bug.cgi?id=23884
Diffstat (limited to 'src/libstd/array.rs')
0 files changed, 0 insertions, 0 deletions